You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by hu...@apache.org on 2018/09/10 16:01:01 UTC
incubator-gobblin git commit: [GOBBLIN-577] pep-0020 - Readability
counts
Repository: incubator-gobblin
Updated Branches:
refs/heads/master 3dcb2336e -> 0ae37a849
[GOBBLIN-577] pep-0020 - Readability counts
Closes #2439 from
SivaMaplelabs/pep-0008-indentation
Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/0ae37a84
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/0ae37a84
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/0ae37a84
Branch: refs/heads/master
Commit: 0ae37a8494fbecbee13001b698271631431d445d
Parents: 3dcb233
Author: SivaMaplelabs <si...@maplelabs.com>
Authored: Mon Sep 10 09:00:56 2018 -0700
Committer: Hung Tran <hu...@linkedin.com>
Committed: Mon Sep 10 09:00:56 2018 -0700
----------------------------------------------------------------------
query_github_issues.py | 91 ++++++++++++++++++++++++---------------------
1 file changed, 49 insertions(+), 42 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/0ae37a84/query_github_issues.py
----------------------------------------------------------------------
diff --git a/query_github_issues.py b/query_github_issues.py
index 0fc372b..4d10b7f 100755
--- a/query_github_issues.py
+++ b/query_github_issues.py
@@ -1,6 +1,7 @@
#!/bin/env /usr/bin/python2.6
-
-from datetime import date,timedelta
+# pylint: disable=missing-docstring
+# pylint: disable=unused-import
+from datetime import date, timedelta
import json
import httplib
from string import Template
@@ -8,42 +9,47 @@ import sys
import urllib
def search_issues(query_terms, sortBy=None, orderDir=None):
- conn = httplib.HTTPSConnection("api.github.com")
- params_map = {"q": "+".join(query_terms)}
- if None != sortBy:
- params_map["sort"] = sortBy
- if None != orderDir:
- params_map["order"] = orderDir
- # Note we don't do urlencode because the output is not compatible with the q syntax, e.g. : and / should not be escaped
- # params = urllib.urlencode(params_map)
- params = "&".join(str(i[0]) + "=" + str(i[1]) for i in params_map.items())
- #print params
+ # pylint: disable=line-too-long
+ # pylint: disable=invalid-name
+ conn = httplib.HTTPSConnection("api.github.com")
+ params_map = {"q": "+".join(query_terms)}
+ if sortBy is not None:
+ params_map["sort"] = sortBy
+ if orderDir is not None:
+ params_map["order"] = orderDir
+ # Note we don't do urlencode because the output is not compatible with the q syntax, e.g. : and / should not be escaped
+ # params = urllib.urlencode(params_map)
+ params = "&".join(str(i[0]) + "=" + str(i[1]) for i in params_map.items())
+ #print params
- headers = {"User-Agent": "Python App"}
+ headers = {"User-Agent": "Python App"}
- conn.request("GET", "/search/issues?" + params, headers=headers)
- response = conn.getresponse()
- if response.status != httplib.OK:
- sys.stderr.write("Query error: %s %s: %s" % (response.status, response.reason, response.read()))
- sys.exit(1)
- result = json.loads(response.read())
- conn.close()
- return result
+ conn.request("GET", "/search/issues?" + params, headers=headers)
+ response = conn.getresponse()
+ if response.status != httplib.OK:
+ sys.stderr.write("Query error: %s %s: %s" % (response.status, response.reason, response.read()))
+ sys.exit(1)
+ result = json.loads(response.read())
+ conn.close()
+ return result
def get_created_issues_since(day):
- return search_issues(query_terms=["repo:linkedin/gobblin", "is:open", "is:issue", "created:>=" + day],
- sortBy="created",
- orderDir="desc"
- )
+ # pylint: disable=line-too-long
+ return search_issues(query_terms=["repo:linkedin/gobblin", "is:open", "is:issue", "created:>=" + day],
+ sortBy="created",
+ orderDir="desc"
+ )
-def get_created_issues_last_days(n = 10):
- since_day = (date.today() - timedelta(days = n)).strftime("%Y-%m-%d")
- return get_created_issues_since(since_day)
+def get_created_issues_last_days(n=10):
+ # pylint: disable=invalid-name
+ since_day = (date.today() - timedelta(days=n)).strftime("%Y-%m-%d")
+ return get_created_issues_since(since_day)
def simple_issue_list(issues):
- HEADER_TEMPLATE = Template("$total_count issues found")
- ISSUE_TEMPLATE = Template("""------------------
+ # pylint: disable=invalid-name
+ HEADER_TEMPLATE = Template("$total_count issues found")
+ ISSUE_TEMPLATE = Template("""------------------
ISSUE $number : HTML: $html_url JSON: $url
\tCREATED ON: $created_at
\tCREATED BY: $user_login ( $user_name ) $user_html_url
@@ -54,19 +60,20 @@ ISSUE $number : HTML: $html_url JSON: $url
$body
""")
- print HEADER_TEMPLATE.substitute(issues)
- for issue in issues["items"]:
- user_data = issue["user"]
- for user_attr in user_data:
- issue["user_" + user_attr] = user_data[user_attr]
- assignee_data = issue["assignee"]
- for assignee_attr in assignee_data:
- issue["assignee_" + assignee_attr] = assignee_data[assignee_attr]
- print ISSUE_TEMPLATE.safe_substitute(issue)
+ print HEADER_TEMPLATE.substitute(issues)
+ for issue in issues["items"]:
+ user_data = issue["user"]
+ for user_attr in user_data:
+ issue["user_" + user_attr] = user_data[user_attr]
+ assignee_data = issue["assignee"]
+ for assignee_attr in assignee_data:
+ issue["assignee_" + assignee_attr] = assignee_data[assignee_attr]
+ print ISSUE_TEMPLATE.safe_substitute(issue)
def main(argv):
- issues = get_created_issues_last_days(7)
- print simple_issue_list(issues)
+ # pylint: disable=unused-argument
+ issues = get_created_issues_last_days(7)
+ print simple_issue_list(issues)
if __name__ == "__main__":
- main(sys.argv[1:])
+ main(sys.argv[1:])