You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/06 01:14:44 UTC
[jira] [Commented] (FLINK-6268) Object reuse for Either type
[ https://issues.apache.org/jira/browse/FLINK-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958137#comment-15958137 ]
ASF GitHub Bot commented on FLINK-6268:
---------------------------------------
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3680
[FLINK-6268] [core] Object reuse for Either type
Implement object reuse for Flink's Either type by storing a reference to Right in Left and Left in Right. These references are private and remain null until set by EitherSerializer when copying or deserializing with object reuse.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 6268_object_reuse_for_either_type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3680
----
commit aa8df2f75a2cfc225db0770f1b56aa36c7bed361
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-04-05T14:12:04Z
[FLINK-6268] [core] Object reuse for Either type
Implement object reuse for Flink's Either type by storing a reference to
Right in Left and Left in Right. These references are private and remain
null until set by EitherSerializer when copying or deserializing with
object reuse.
----
> Object reuse for Either type
> ----------------------------
>
> Key: FLINK-6268
> URL: https://issues.apache.org/jira/browse/FLINK-6268
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.3.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Minor
>
> While reviewing test coverage for FLINK-4705 I have come across that {{Either}} only implements partial object reuse (when from and to are both {{Right}}). We can implement full object reuse if {{Left}} stores a reference to a {{Right}} and {{Right}} to a {{Left}}. These references will be {{private}} and will remain {{null}} until set by {{EitherSerializer}} when copying or deserializing with object reuse.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)