[GitHub] [kafka] jeqo commented on a change in pull request #10869: KAFKA-10546: Deprecate old PAPI

[GitBox <gi...@apache.org>]

jeqo commented on a change in pull request #10869:
URL: https://github.com/apache/kafka/pull/10869#discussion_r653516716



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##########
@@ -1558,7 +1558,7 @@ void to(final TopicNameExtractor<K, V> topicExtractor,
      * @param windows     the specification of the {@link JoinWindows}
      * @param <VO>        the value type of the other stream
      * @param <VR>        the value type of the result stream
-     * @return a {@code KStream} that contains join-records for each key and values computed by the given
+     * @return a {@code KStream} that contains join-recordshttps://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/Admin.java for each key and values computed by the given

Review comment:
       nit: this seems like a typo?

##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##########
@@ -4615,7 +4732,110 @@ void to(final TopicNameExtractor<K, V> topicExtractor,
      * @see #foreach(ForeachAction)
      * @see #transform(TransformerSupplier, String...)
      */
-    void process(final ProcessorSupplier<? super K, ? super V> processorSupplier,
+    <KOut, VOut> void process(final ProcessorSupplier<? super K, ? super V, KOut, VOut> processorSupplier,
+                              final String... stateStoreNames);

Review comment:
       @vvcephei +1 I like the last proposal: using `Void` and keep the option to migrate to `K/V` later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org