You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "piotrnarajowski (via GitHub)" <gi...@apache.org> on 2024/09/10 09:03:31 UTC
[PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
piotrnarajowski opened a new pull request, #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860
ble_gap_ext_adv_params_tx should check if PHY options != 0 Also rename variables for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860#issuecomment-2340092007
Scheduled PR https://github.com/apache/mynewt-nimble/pull/1860#issuecomment-2340090361, board: nrf52, estimated start time: 11:06:05, test case count: 30, estimated duration: 0:20:17<details><summary>Test cases to be run</summary>GAP/BROB/BCST/BV-01-C<br>GAP/BROB/BCST/BV-02-C<br>GAP/BROB/BCST/BV-03-C<br>GAP/BROB/BCST/BV-04-C<br>GAP/BROB/OBSV/BV-01-C<br>GAP/BROB/OBSV/BV-02-C<br>GAP/BROB/OBSV/BV-05-C<br>GAP/BROB/OBSV/BV-06-C<br>GAP/DISC/NONM/BV-01-C<br>GAP/DISC/NONM/BV-02-C<br>GATT/CL/GAC/BV-01-C<br>GATT/CL/GAD/BV-01-C<br>GATT/CL/GAD/BV-02-C<br>GATT/CL/GAD/BV-03-C<br>GATT/CL/GAD/BV-04-C<br>GATT/CL/GAD/BV-05-C<br>GATT/CL/GAD/BV-06-C<br>GATT/CL/GAR/BV-01-C<br>GATT/CL/GAR/BI-01-C<br>GATT/CL/GAR/BI-02-C<br>L2CAP/COS/CFC/BV-01-C<br>L2CAP/COS/CFC/BV-02-C<br>L2CAP/COS/CFC/BV-03-C<br>L2CAP/COS/CFC/BV-04-C<br>L2CAP/COS/CFC/BV-05-C<br>L2CAP/COS/ECFC/BV-01-C<br>L2CAP/COS/ECFC/BV-02-C<br>L2CAP/COS/ECFC/BV-03-C<br>L2CAP/COS/ECFC/BV-04-C<br>L2CAP/LE/CPU/BV-01-C</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on PR #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860#issuecomment-2340336878
@rahult-github we will rename opts to keep this consistent with primary_phy and secundary_phy members in that structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860#discussion_r1751732731
##########
nimble/include/nimble/hci_common.h:
##########
@@ -1153,8 +1153,8 @@ struct ble_hci_le_subrate_req_cp {
#define BLE_HCI_OCF_LE_SET_EXT_ADV_PARAM_V2 (0x007F)
struct ble_hci_le_set_ext_adv_params_v2_cp {
struct ble_hci_le_set_ext_adv_params_cp cmd;
- uint8_t pri_phy_opt;
- uint8_t sec_phy_opt;
+ uint8_t primary_phy_opt;
Review Comment:
this should be left as is, on HCI we have pri_phy and sec_phy (and this is internal anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
Posted by "piotrnarajowski (via GitHub)" <gi...@apache.org>.
piotrnarajowski commented on code in PR #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860#discussion_r1751737816
##########
nimble/include/nimble/hci_common.h:
##########
@@ -1153,8 +1153,8 @@ struct ble_hci_le_subrate_req_cp {
#define BLE_HCI_OCF_LE_SET_EXT_ADV_PARAM_V2 (0x007F)
struct ble_hci_le_set_ext_adv_params_v2_cp {
struct ble_hci_le_set_ext_adv_params_cp cmd;
- uint8_t pri_phy_opt;
- uint8_t sec_phy_opt;
+ uint8_t primary_phy_opt;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860#issuecomment-2340192914
AutoPTS Bot results:
<details><summary>Failed tests</summary>GAP GAP/BROB/BCST/BV-04-C FAIL<br>L2CAP L2CAP/COS/ECFC/BV-01-C BTP ERROR</details>
<details><summary>Successful tests</summary>GAP GAP/BROB/BCST/BV-01-C PASS<br>GAP GAP/BROB/BCST/BV-02-C PASS<br>GAP GAP/BROB/BCST/BV-03-C PASS<br>GAP GAP/BROB/OBSV/BV-01-C PASS<br>GAP GAP/BROB/OBSV/BV-02-C PASS<br>GAP GAP/BROB/OBSV/BV-05-C PASS<br>GAP GAP/BROB/OBSV/BV-06-C PASS<br>GAP GAP/DISC/NONM/BV-01-C PASS<br>GAP GAP/DISC/NONM/BV-02-C PASS<br>GATT GATT/CL/GAC/BV-01-C PASS<br>GATT GATT/CL/GAD/BV-01-C PASS<br>GATT GATT/CL/GAD/BV-02-C PASS<br>GATT GATT/CL/GAD/BV-03-C PASS<br>GATT GATT/CL/GAD/BV-04-C PASS<br>GATT GATT/CL/GAD/BV-05-C PASS<br>GATT GATT/CL/GAD/BV-06-C PASS<br>GATT GATT/CL/GAR/BI-01-C PASS<br>GATT GATT/CL/GAR/BI-02-C PASS<br>GATT GATT/CL/GAR/BV-01-C PASS<br>L2CAP L2CAP/COS/CFC/BV-01-C
PASS<br>L2CAP L2CAP/COS/CFC/BV-02-C PASS<br>L2CAP L2CAP/COS/CFC/BV-03-C PASS<br>L2CAP L2CAP/COS/CFC/BV-04-C PASS<br>L2CAP L2CAP/COS/CFC/BV-05-C PASS<br>L2CAP L2CAP/COS/ECFC/BV-02-C PASS<br>L2CAP L2CAP/COS/ECFC/BV-03-C PASS<br>L2CAP L2CAP/COS/ECFC/BV-04-C PASS<br>L2CAP L2CAP/LE/CPU/BV-01-C PASS</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
Posted by "piotrnarajowski (via GitHub)" <gi...@apache.org>.
piotrnarajowski commented on PR #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860#issuecomment-2340090361
#AutoPTS run mynewt GAP GATT L2cap --test-case-limit 10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Fix ble_gap_ext_adv_params_tx and rename variables [mynewt-nimble]
Posted by "piotrnarajowski (via GitHub)" <gi...@apache.org>.
piotrnarajowski commented on PR #1860:
URL: https://github.com/apache/mynewt-nimble/pull/1860#issuecomment-2340300598
FYI @rahult-github
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org