Re: SonarQube plugin for Gradle

[Jacques Le Roux <ja...@les7arts.com>]

Hi,

All is done with https://issues.apache.org/jira/browse/OFBIZ-12284

Jacques

Le 20/07/2021 à 17:57, Jacques Le Roux a écrit :
> Hi,
>
> A lot of the so called bugs by SonarQube are actually false-positive. I have asked Infra the right to mark them as they are with 
> https://issues.apache.org/jira/browse/INFRA-22121
>
> It's not a big deal, but since Drew (of Infra) asked, anyone else interesting to help in this aspect?
>
> Thanks
>
> Jacques
>
> Le 17/07/2021 à 09:20, Jacques Le Roux a écrit :
>> Hi,
>>
>> The SonarQube Gradle plugin to work needs a SonarQube instance running somewhere : https://docs.sonarqube.org/latest/setup/get-started-2-minutes/
>> And it requires Java 11 to run : https://docs.sonarqube.org/latest/requirements/requirements/
>>
>> So we are not ready yet. Later we could run a SonarQube instance on the OFBiz demo server and refer to it from the Gradle plugin. I don't see 
>> everybody running a SonarQube instance locally.
>>
>> I wonder though what the interest would be for us. I understand GH POV, less burden on their servers. For us it complicates quite the things. So 
>> I'd rather suggest to stay as it is.
>>
>> This is for instance interesting at no cost:
>>
>> https://sonarcloud.io/dashboard?id=apache_ofbiz-framework <https://sonarcloud.io/dashboard?id=apache_ofbiz-framework>
>> https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins <https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins>
>>
>> For instance I stumbled upon:
>> https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&metric=new_reliability_rating&view=list
>> I'll open a OFBIZ-12276 subtask for that and will check other cases
>>
>> BTW I have closed https://issues.apache.org/jira/browse/OFBIZ-10917
>>
>> Jacques
>>
>> Le 12/07/2021 à 08:10, Pierre Smits a écrit :
>>> Great!
>>>
>>> Pierre Smits
>>>
>>>
>>> On Sun, Jul 11, 2021 at 3:49 PM Jacques Le Roux <
>>> jacques.le.roux@les7arts.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I have just created https://issues.apache.org/jira/browse/INFRA-22099 for
>>>> that
>>>>
>>>> Jacques
>>>>
>>>> Le 27/06/2021 à 18:52, Jacques Le Roux a écrit :
>>>>> Hi,
>>>>>
>>>>> I checked, the GH actions are in
>>>> https://github.com/apache/ofbiz-framework/blob/trunk/.github/workflows/gradle.yaml
>>>>> Clearly SonarQube is not there. So it's indeed Infra thing. I'll check
>>>> with them, after checking what it means to use it in Gradle...
>>>>> Jacques
>>>>>
>>>>> Le 01/06/2021 à 11:23, Jacques Le Roux a écrit :
>>>>>> Hi Pierre,
>>>>>>
>>>>>> I'm not sure. I think it's an Infra thing, I'll check that.
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> Le 01/06/2021 à 10:12, Pierre Smits a écrit :
>>>>>>> Hi Jacques,
>>>>>>>
>>>>>>> Did we implement a GitHub action to invoke the SonarQube analysis?
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Pierre Smits
>>>>>>>
>>>>>>> On Mon, May 31, 2021 at 6:02 PM Jacques Le Roux <
>>>>>>> jacques.le.roux@les7arts.com> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Just stumbled upon this :
>>>>>>>>
>>>>>>>>       <<Do not use this GitHub action if you are in the following
>>>> situations
>>>>>>>>         * Your code is built with Gradle: use the SonarQube plugin for
>>>>>>>> Gradle during the build>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>> https://github.com/SonarSource/sonarcloud-github-action#user-content-do-not-use-this-github-action-if-you-are-in-the-following-situations
>>>>>>>> So I think we should remove it from GH and rather use it with Gradle.
>>>> Not
>>>>>>>> sure about all that though...
>>>>>>>>
>>>>>>>> Opinions ?
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>