You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/07/12 21:20:02 UTC
[GitHub] [incubator-pinot] jackjlli opened a new issue #7156: Make configs for controller periodic tasks human readable
jackjlli opened a new issue #7156:
URL: https://github.com/apache/incubator-pinot/issues/7156
The current configs for controller periodic tasks have to use number in seconds, which is not convenient.
We can introduce a new set of configs to make them human readable, like `2h30m`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on issue #7156: Make configs for controller periodic tasks human readable
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on issue #7156:
URL: https://github.com/apache/incubator-pinot/issues/7156#issuecomment-882077225
Thank you for your contribution, one of the committers will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suddendust commented on issue #7156: Make configs for controller periodic tasks human readable
Posted by GitBox <gi...@apache.org>.
suddendust commented on issue #7156:
URL: https://github.com/apache/incubator-pinot/issues/7156#issuecomment-881348521
I have picked this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on issue #7156: Make configs for controller periodic tasks human readable
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on issue #7156:
URL: https://github.com/apache/incubator-pinot/issues/7156#issuecomment-880933728
Sure, please do. Just make sure that we accept _both_ old and new configurations, and prefer the new one if both or specified. Be sure to change the documentation as well to say that these new configs have been introduced and the old ones deprecated.
[Sigh!] we have no way of deprecating configurations to make them easily visible for admin (other than release notes), so please tag your PR with release noes, and mention what needs to go in there.
Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suddendust commented on issue #7156: Make configs for controller periodic tasks human readable
Posted by GitBox <gi...@apache.org>.
suddendust commented on issue #7156:
URL: https://github.com/apache/incubator-pinot/issues/7156#issuecomment-882013098
@mcvsubbu I have raise a preliminary PR for this #7173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on issue #7156: Make configs for controller periodic tasks human readable
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on issue #7156:
URL: https://github.com/apache/incubator-pinot/issues/7156#issuecomment-880228163
Exactly, that is the idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #7156: Make configs for controller periodic tasks human readable
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7156:
URL: https://github.com/apache/incubator-pinot/issues/7156#issuecomment-880225449
Currently we have `frequencyInSeconds`, `initialDelayInSeconds` etc. We can add another set of configs `frequencyPeriod`, `initialDelayPeriod` which takes the human readable period string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suddendust commented on issue #7156: Make configs for controller periodic tasks human readable
Posted by GitBox <gi...@apache.org>.
suddendust commented on issue #7156:
URL: https://github.com/apache/incubator-pinot/issues/7156#issuecomment-880910805
Hey @mcvsubbu can I pick this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org