You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/13 10:44:25 UTC
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8497: Fixed TLS using scheme HTTP when using TRI protocol

codecov-commenter edited a comment on pull request #8497:
URL: https://github.com/apache/dubbo/pull/8497#issuecomment-898365419


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8497?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8497](https://codecov.io/gh/apache/dubbo/pull/8497?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e51f816) into [3.0](https://codecov.io/gh/apache/dubbo/commit/b5e65a6d25758bd459a5d8898feeaae32f6c388f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b5e65a6) will **decrease** coverage by `0.01%`.
   > The diff coverage is `66.66%`.
   
   > :exclamation: Current head e51f816 differs from pull request most recent head c46e125. Consider uploading reports for the commit c46e125 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8497/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8497      +/-   ##
   ============================================
   - Coverage     62.85%   62.83%   -0.02%     
   - Complexity      311      312       +1     
   ============================================
     Files          1113     1113              
     Lines         46660    46612      -48     
     Branches       7020     6987      -33     
   ============================================
   - Hits          29326    29290      -36     
   + Misses        14077    14064      -13     
   - Partials       3257     3258       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `79.59% <50.00%> (-3.39%)` | :arrow_down: |
   | [...he/dubbo/rpc/protocol/tri/TripleClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50SGFuZGxlci5qYXZh) | `54.54% <100.00%> (+1.05%)` | :arrow_up: |
   | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2ZpeGVkL0ZpeGVkVGhyZWFkUG9vbC5qYXZh) | `80.00% <0.00%> (-7.50%)` | :arrow_down: |
   | [...moting/transport/netty4/NettyEventLoopFactory.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5RXZlbnRMb29wRmFjdG9yeS5qYXZh) | `30.00% <0.00%> (-6.37%)` | :arrow_down: |
   | [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2xpbWl0ZWQvTGltaXRlZFRocmVhZFBvb2wuamF2YQ==) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
   | [...ache/dubbo/remoting/api/NettyEventLoopFactory.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvTmV0dHlFdmVudExvb3BGYWN0b3J5LmphdmE=) | `36.36% <0.00%> (-5.31%)` | :arrow_down: |
   | [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2NhY2hlZC9DYWNoZWRUaHJlYWRQb29sLmphdmE=) | `85.71% <0.00%> (-4.29%)` | :arrow_down: |
   | [...port/identifier/BaseServiceMetadataIdentifier.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvaWRlbnRpZmllci9CYXNlU2VydmljZU1ldGFkYXRhSWRlbnRpZmllci5qYXZh) | `63.63% <0.00%> (-4.23%)` | :arrow_down: |
   | [.../org/apache/dubbo/qos/legacy/LogTelnetHandler.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2xlZ2FjeS9Mb2dUZWxuZXRIYW5kbGVyLmphdmE=) | `30.30% <0.00%> (-3.04%)` | :arrow_down: |
   | [...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9BYnN0cmFjdFByb3h5UHJvdG9jb2wuamF2YQ==) | `58.33% <0.00%> (-2.39%)` | :arrow_down: |
   | ... and [38 more](https://codecov.io/gh/apache/dubbo/pull/8497/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8497?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8497?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b5e65a6...c46e125](https://codecov.io/gh/apache/dubbo/pull/8497?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org