You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Ryan Stewart (Created) (JIRA)" <ji...@apache.org> on 2012/04/10 10:26:14 UTC
[jira] [Created] (CB-470) Example in Camera Docs Not Working
Example in Camera Docs Not Working
----------------------------------
Key: CB-470
URL: https://issues.apache.org/jira/browse/CB-470
Project: Apache Callback
Issue Type: Bug
Components: Docs
Affects Versions: 1.6.0
Reporter: Ryan Stewart
Assignee: Michael Brooks
Priority: Trivial
There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-470) Example in Camera Docs Not Working
Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250809#comment-13250809 ]
Shazron Abdullah commented on CB-470:
-------------------------------------
Missed that, sorry. But looks like we both missed capturePhotoEdit as well! That needs the DATA_URL
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Michael Brooks
> Priority: Trivial
> Fix For: 1.6.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-470) Example in Camera Docs Not Working
Posted by "Ryan Stewart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250815#comment-13250815 ]
Ryan Stewart commented on CB-470:
---------------------------------
Yeah, I noticed that too on second look. I'll redo my patch and fix both of them then submit a pull request (if that's the right way to do it).
Thanks Shazron!
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Shazron Abdullah
> Priority: Trivial
> Fix For: 1.6.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-470) Example in Camera Docs Not Working
Posted by "Shazron Abdullah (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250821#comment-13250821 ]
Shazron Abdullah commented on CB-470:
-------------------------------------
If you push to the same branch as that pull request, github should pick it up automatically
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Shazron Abdullah
> Priority: Trivial
> Fix For: 1.6.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (CB-470) Example in Camera Docs Not Working
Posted by Ryan Stewart <rs...@adobe.com>.
It's a small fix, but I'm mostly trying to get the process down. I submitted the CLA last night but don't know how long it takes to process. And it seemed like the general way to submit a fix to the Apache Git repo is to have a fork of the Github repo and submit pull requests from there (as a noncommitter). Is that correct?
=Ryan
On Apr 10, 2012, at 9:19 AM, Ryan Stewart (Commented) (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250785#comment-13250785 ]
>
> Ryan Stewart commented on CB-470:
> ---------------------------------
>
> I've got a pull request in to fix this - https://github.com/apache/incubator-cordova-docs/pull/6
>
>> Example in Camera Docs Not Working
>> ----------------------------------
>>
>> Key: CB-470
>> URL: https://issues.apache.org/jira/browse/CB-470
>> Project: Apache Callback
>> Issue Type: Bug
>> Components: Docs
>> Affects Versions: 1.6.0
>> Reporter: Ryan Stewart
>> Assignee: Michael Brooks
>> Priority: Trivial
>> Original Estimate: 24h
>> Remaining Estimate: 24h
>>
>> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Commented] (CB-470) Example in Camera Docs Not Working
Posted by "Ryan Stewart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250785#comment-13250785 ]
Ryan Stewart commented on CB-470:
---------------------------------
I've got a pull request in to fix this - https://github.com/apache/incubator-cordova-docs/pull/6
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Michael Brooks
> Priority: Trivial
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-470) Example in Camera Docs Not Working
Posted by "Shazron Abdullah (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah resolved CB-470.
---------------------------------
Resolution: Duplicate
Fix Version/s: 1.6.0
Thanks Ryan, but this is a dupe of CB-243. I see that you also fixed the tagged 1.6.0rc1, usually the fix would go in Edge only (which is going to be tagged 1.6.0 soon), but I could be wrong about that.
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Michael Brooks
> Priority: Trivial
> Fix For: 1.6.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-470) Example in Camera Docs Not Working
Posted by "Filip Maj (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-470.
--------------------------
Resolution: Fixed
Fixed in [46a6fd|http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-docs.git;a=commit;h=46a6fd3ffc619402b5c834bd78941a4f49c3a858].
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Shazron Abdullah
> Priority: Trivial
> Fix For: 1.6.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-470) Example in Camera Docs Not Working
Posted by "Ryan Stewart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250800#comment-13250800 ]
Ryan Stewart commented on CB-470:
---------------------------------
Good to know about where to check it in. It looks like the full example on Edge is still wrong though, as it's not specifying DATA_URL. The quick example looks like it's been fixed but not the capturePhoto() method of the full example. This patches that as well.
But am I looking at that wrong?
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Michael Brooks
> Priority: Trivial
> Fix For: 1.6.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-470) Example in Camera Docs Not Working
Posted by "Ryan Stewart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250842#comment-13250842 ]
Ryan Stewart commented on CB-470:
---------------------------------
Whoops, I just went from scratch so I'd only push to Edge. New pull request here - https://github.com/apache/incubator-cordova-docs/pull/7
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Shazron Abdullah
> Priority: Trivial
> Fix For: 1.6.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CB-470) Example in Camera Docs Not Working
Posted by "Shazron Abdullah (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shazron Abdullah reopened CB-470:
---------------------------------
Assignee: Shazron Abdullah (was: Michael Brooks)
> Example in Camera Docs Not Working
> ----------------------------------
>
> Key: CB-470
> URL: https://issues.apache.org/jira/browse/CB-470
> Project: Apache Callback
> Issue Type: Bug
> Components: Docs
> Affects Versions: 1.6.0
> Reporter: Ryan Stewart
> Assignee: Shazron Abdullah
> Priority: Trivial
> Fix For: 1.6.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There's a small issue with the Camera API docs because it seems like the example was written when DATA_URL was the default destinationType. So the capturePhoto() method doesn't behave correctly because it assumes a destinationType of DATA_URL when the type being passed is FILE_URI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira