You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/01 00:16:13 UTC

[GitHub] [incubator-mxnet] connorgoggins opened a new pull request #17948: [Website 2.0] General Version Dropdown

connorgoggins opened a new pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948
 
 
   ## Description ##
   This PR resolves the issues outlined in the Github issue for the [MXNet Website 2.0 General Version Dropdown](https://github.com/apache/incubator-mxnet/issues/17798). It serves to add a fully functional API version dropdown with consistent styling to the master website, and also modifies the Jenkins build instructions to download static artifacts from an [external repository](https://github.com/connorgoggins/mxnet-website-artifacts). Currently, this repository of static artifacts includes websites for the following past versions of the MXNet API:
   - 1.6
   - 1.5.0
   - 1.4.1
   - 1.3.1
   - 1.2.1
   - 1.1.0
   - 1.0.0
   - 0.11.0
   - 0.12.1
   
   Each version of the website also has a similarly formatted API version dropdown in the header of each page, making it easy for users to seamlessly navigate between different versions of the MXNet website.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] Code is well-documented
   - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - M docs/python_docs/themes/mx-theme/mxtheme/header_top.html
   - M docs/python_docs/themes/mx-theme/mxtheme/layout.html
   - M docs/static_site/Makefile
   - M docs/static_site/src/_includes/head.html
   - M docs/static_site/src/_includes/header.html
   
   ## Comments ##
   Preview is currently available [here](http://ec2-3-19-223-185.us-east-2.compute.amazonaws.com/).
   
   
   @sandeep-krishnamurthy @aaronmarkham @szha @sojiadeshina @leezu

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402439879
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   Here's an idea: add this to the Dockerfile so that it gets cached as part of the image and we don't have to grab that zip every time there's a test or build.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-607977853
 
 
   @marcoabreu see "Jenkins Artifact Generation" within the Static Artifact Publication section of the [wiki page](https://w.amazon.com/bin/view/Deep-engine/MXNet-Website-Redesign/Instructions-for-Adding-Future-Releases/) for detailed instructions on how to add a new artifact, create `versions.zip`, and upload to S3.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-607543206
 
 
   @szha I created two PRs with changes that will add Jenkinsfiles to support nightly builds for [v1.x](https://github.com/apache/incubator-mxnet/pull/17956) and [v2.x (master)](https://github.com/apache/incubator-mxnet/pull/17957). When you have some free time, would you mind reviewing them?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402572325
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   Agreed @szha. The priority right now should be getting the working version dropdown in this PR into the production site as soon as possible.
   
   @marcoabreu, I have created a [confluence page](https://cwiki.apache.org/confluence/display/MXNET/Instructions+for+Adding+Future+Releases) so that all contributors can understand and reproduce the steps to add additional releases to the website. In the future, we will move towards creating dynamic pipelines to automatically generate and integrate new releases of MXNet into the website, but for now I believe the static artifact solution + master integration in this PR serves its purpose.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401754843
 
 

 ##########
 File path: docs/python_docs/themes/mx-theme/mxtheme/header_top.html
 ##########
 @@ -19,6 +19,21 @@
         <a class="page-link" href="{{theme_relative_url}}ecosystem">Ecosystem</a>
         <a class="page-link page-current" href="{{theme_relative_url}}api">Docs & Tutorials</a>
         <a class="page-link" href="https://github.com/apache/incubator-mxnet">GitHub</a>
+        <div class="dropdown">
+          <span style="color:#FFFFFF">master</span>
 
 Review comment:
   +1 to Sheng's comment. 
   I remember someone recommending "Document Version" like in Apache Spark and other open source project. Does that fit here? @szha @aaronmarkham 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402712059
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	git clone --recursive https://github.com/connorgoggins/mxnet-website-artifacts.git && mv mxnet-website-artifacts/versions/ build/html/ && rm -rf mxnet-website-artifacts
 
 Review comment:
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402714515
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   @marcoabreu Thanks for your feedback and I fully agree that if generation of web content happens through Jenkins in an automated way, all community members can participate in the updates. In that direction, @connorgoggins already has PRs to make 1.x and 2.x branches auto builds. The fix here is very critical for MXNet community. Without this change, users are unable to use MXNet website. One concern would be if there is a patch release on 1.6.x then someone needs to regenerate static artifacts. Given that @connorgoggins already documented steps for the same and his other contributions I see this as a non-blocking issue that will not leave MXNet community in limbo.
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402008073
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   Where does that come from? It seems like we're breaking out of a context here. S3 should not be the method how multiple Jenkins jobs exchange data

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] szha commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402568771
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   Indeed, this is a static artifact that can't be directly updated by the community. For a complete solution, we definitely need them to be generated.
   
   On the other hand, the lack of website versioning is such a pressing issue that it has come up multiple times, even in past release votes, and is still actively causing confusion for many current and prospective users. We must be losing user base because of this.
   
   If the contributors could come up with a plan for a solution that's based on automatically generated content, and execute the plan before any of our next releases, I think we should accept this solution for now to address the immediate need for avoiding confusion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r403048182
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   Sounds good to me. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] marcoabreu commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
marcoabreu commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-607771508
 
 
   To me it's unclear how that magic versions.zip gets created. Could you maybe make a diagram of how the individual versions get created, where they are stored and how they are merged? Some data flow would be good

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401838431
 
 

 ##########
 File path: docs/python_docs/themes/mx-theme/mxtheme/layout.html
 ##########
 @@ -7,6 +7,27 @@
     <meta charset="utf-8">
     <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
     <meta http-equiv="x-ua-compatible" content="ie=edge">
+    <style>
+    .dropdown {
 
 Review comment:
   Sure, I'll create a document/wiki page with styling info once the design is finalized.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] szha commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402570051
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   I see that @connorgoggins is already contributing other PRs in this direction (#17956 #17957), I trust that the contributor has the intention to make the generation automated. @connorgoggins @sandeep-krishnamurthy contingent on if you could spell out a plan for automated generation for the website, I support accepting this patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] szha commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
szha commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-608030179
 
 
   The updated style looks good to me. Thanks @connorgoggins

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402024023
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   Thanks for your question, @marcoabreu. The content for the static artifacts is managed in [this repository](https://github.com/connorgoggins/mxnet-website-artifacts). Originally this line was a call to directly clone the repository, but based on feedback it was decided that it would be better to not rely on external repositories and pull the artifacts from an S3 bucket instead.
   
   Here, S3 isn't being used as the way multiple Jenkins jobs exchange data per se. There are many older static artifacts in the ZIP that have gone through multiple rounds of changes which are tracked in the aforementioned repository, rather than simply being built by another Jenkins pipeline.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy merged pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402037570
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	git clone --recursive https://github.com/connorgoggins/mxnet-website-artifacts.git && mv mxnet-website-artifacts/versions/ build/html/ && rm -rf mxnet-website-artifacts
 
 Review comment:
   @sandeep-krishnamurthy update: I've incorporated and successfully tested a new round of changes that uses `wget` to pull the artifacts from S3 instead of the personal repo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401798079
 
 

 ##########
 File path: docs/python_docs/themes/mx-theme/mxtheme/header_top.html
 ##########
 @@ -19,6 +19,21 @@
         <a class="page-link" href="{{theme_relative_url}}ecosystem">Ecosystem</a>
         <a class="page-link page-current" href="{{theme_relative_url}}api">Docs & Tutorials</a>
         <a class="page-link" href="https://github.com/apache/incubator-mxnet">GitHub</a>
+        <div class="dropdown">
+          <span style="color:#FFFFFF">master</span>
+          <div class="dropdown-content">
+            <a style="color:#FF4500;font-weight: lighter;" href="/">master</a><br>
 
 Review comment:
   Can you move styles to central css file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-608075766
 
 
   @marcoabreu the [Confluence page](https://cwiki.apache.org/confluence/display/MXNET/Instructions+for+Adding+Future+Releases) with instructions for adding releases is now public.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] szha commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
szha commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-607044065
 
 
   Thanks for introducing the versioned website.
   
   In terms of appearance, could we make the version selector more visually distinct from other links? From the current look it doesn't seem obvious that a dropdown menu is there.
   ![image](https://user-images.githubusercontent.com/2626883/78102744-e956de00-739f-11ea-901d-9b6684eb3e68.png)
   ![image](https://user-images.githubusercontent.com/2626883/78102751-ef4cbf00-739f-11ea-9e82-8977bdd90de9.png)
   
   Another ask is that since we are maintaining both the mxnet 1.x (v1.x branch, w/ 1.7 to be the next version) and 2.x (master branch, w/ 2.0 to be the next version), can we make nightly builds for these dev branches available? See https://github.com/apache/incubator-mxnet/issues/17701 for details.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401797451
 
 

 ##########
 File path: docs/static_site/src/_includes/head.html
 ##########
 @@ -15,4 +15,25 @@
 
   <script src="{{'/assets/js/clipboard.js'|relative_url}}"></script>
   <script src="{{'/assets/js/copycode.js'|relative_url}}"></script>
+  <style>
 
 Review comment:
   Duplicated in layout.html. Should be abstracted to a single source so it's easier to manage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-607402049
 
 
   @szha thanks for your feedback! I would be happy to modify the styling of the version dropdown. Can you give me an idea of what exactly you had in mind?
   
   Regarding the nightly build configurations, since v1.x and v2.x use restricted nodes (see [Jenkinsfile_website_full](https://github.com/apache/incubator-mxnet/blob/v1.x/ci/jenkins/Jenkinsfile_website_full)) these builds would need to be run on prod Jenkins, which I currently do not have admin access to. At the moment, I am trying to get access to prod Jenkins so I can set up these nightly build pipelines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-606954345
 
 
   Hey @connorgoggins , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [clang, edge, centos-gpu, centos-cpu, windows-cpu, miscellaneous, unix-cpu, windows-gpu, unix-gpu, website, sanity]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401797705
 
 

 ##########
 File path: docs/static_site/src/_includes/header.html
 ##########
 @@ -43,6 +43,21 @@
         <a class="page-link" href="{{'/ecosystem' | relative_url }}">Ecosystem</a>
         <a class="page-link" href="{{'/api' | relative_url }}">Docs & Tutorials</a>
         <a class="page-link" href="https://github.com/apache/incubator-mxnet">GitHub</a>
+        <div class="dropdown">
+          <span>master</span>
+          <div class="dropdown-content">
+            <a style="color:#FF4500;" href="/">master</a>
 
 Review comment:
   move to central css

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-607632487
 
 
   Update: the [new version of the website preview](http://ec2-3-19-223-185.us-east-2.compute.amazonaws.com/) reflects the changes I have made to this PR to incorporate feedback. @szha the styling of the dropdown in 1.6 and master has been updated to more clearly indicate that the menu option is a dropdown.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401820661
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	git clone --recursive https://github.com/connorgoggins/mxnet-website-artifacts.git && mv mxnet-website-artifacts/versions/ build/html/ && rm -rf mxnet-website-artifacts
 
 Review comment:
   I tried storing the artifacts in S3 and pulling them with `wget` in the Makefile, but the Jenkins slave doesn't seem to have the `wget` package installed so I thought just cloning them directly from the repo would be more straightforward. I'll investigate how to get the `wget` package onto the Jenkins slave so we can pull the artifacts from S3 instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401796812
 
 

 ##########
 File path: docs/python_docs/themes/mx-theme/mxtheme/layout.html
 ##########
 @@ -7,6 +7,27 @@
     <meta charset="utf-8">
     <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
     <meta http-equiv="x-ua-compatible" content="ie=edge">
+    <style>
+    .dropdown {
 
 Review comment:
   Can you make sure all of the style stuff is documented - so we know what it does and how it interacts with all of the other pieces? Like how does this interact with this?
   https://github.com/apache/incubator-mxnet/blob/master/docs/python_docs/_static/mxnet.css
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] marcoabreu commented on issue #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
marcoabreu commented on issue #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#issuecomment-607985043
 
 
   I'm no longer an Amazon employee. This content should be hosted on confluence. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401756646
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	git clone --recursive https://github.com/connorgoggins/mxnet-website-artifacts.git && mv mxnet-website-artifacts/versions/ build/html/ && rm -rf mxnet-website-artifacts
 
 Review comment:
   I suggest to not have artifacts in personal repo. We were planning to keep the artifacts in public readable MXNet assets bucket / similar?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r402484692
 
 

 ##########
 File path: docs/static_site/Makefile
 ##########
 @@ -20,7 +20,7 @@ all: html
 html:
 	mkdir -p build
 	cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd ..
-
+	wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip
 
 Review comment:
   But how would you invalidate that cache? 
   
   I think it's important to have continuity to allow a contributor to understand and also reproduce how our website gets created. As it stands right now, people would not be able to facilitate this. 
   
   What happened to the idea with the Jenkins jobs creating artifacts and another job consuming these artifacts to then assemble the website?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown

Posted by GitBox <gi...@apache.org>.
connorgoggins commented on a change in pull request #17948: [Website 2.0] General Version Dropdown
URL: https://github.com/apache/incubator-mxnet/pull/17948#discussion_r401818452
 
 

 ##########
 File path: docs/python_docs/themes/mx-theme/mxtheme/header_top.html
 ##########
 @@ -19,6 +19,21 @@
         <a class="page-link" href="{{theme_relative_url}}ecosystem">Ecosystem</a>
         <a class="page-link page-current" href="{{theme_relative_url}}api">Docs & Tutorials</a>
         <a class="page-link" href="https://github.com/apache/incubator-mxnet">GitHub</a>
+        <div class="dropdown">
+          <span style="color:#FFFFFF">master</span>
 
 Review comment:
   Thanks for the feedback Sandeep! I'd be happy to change the dropdown to follow this format if that is the general consensus.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services