[GitHub] [pinot] xiangfu0 commented on a change in pull request #8162: Disable recursion in PinotFS copy

[GitBox <gi...@apache.org>]

xiangfu0 commented on a change in pull request #8162:
URL: https://github.com/apache/pinot/pull/8162#discussion_r801292188



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java
##########
@@ -143,7 +143,7 @@ long length(URI fileUri)
 
   /**
    * Copies a file from a remote filesystem to the local one. Keeps the original file.
-   * @param srcUri location of current file on remote filesystem
+   * @param srcUri location of current file on remote filesystem (must not be a directory)

Review comment:
       Do we have any usage that requires directory copy?
   Shall we consider add a new API like `copySingleFile(...)` or add a flag parameter `isRecursive`?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org