[jira] [Updated] (IMAGING-159) There should be a Parameters class

["Bruno P. Kinoshita (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMAGING-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno P. Kinoshita updated IMAGING-159:
---------------------------------------
    Affects Version/s: 1.0-alpha2

> There should be a Parameters class
> ----------------------------------
>
>                 Key: IMAGING-159
>                 URL: https://issues.apache.org/jira/browse/IMAGING-159
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: imaging.*
>    Affects Versions: 1.0-alpha2
>            Reporter: Benedikt Ritter
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>              Labels: github
>             Fix For: Review Patch
>
>
> Currently options for image I/O are defined as Maps. The leads to the problem that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
>   if (!(value instanceof Number)) {
>     throw new ImageWriteException(
>       "Invalid compression parameter, must be numeric: "
>          + value);
>   }
>   compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides additional methods like {{public int getInt(String key)}}. The implementation could then look up the value from the map through an exception if it is null or not a number.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)