[jira] [Commented] (OPENNLP-653) Entity linker factory should not require the "entity type" parameter

["Mark Giaconia (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914502#comment-13914502 ] 

Mark Giaconia commented on OPENNLP-653:
---------------------------------------

would this mean the properties file will only support one linker type? The reason it has a type param is so you can have multiple linkers defined in one properties file. It would work either way, but a lot of people have a standard properties file their system uses for a bunch of components, and having the type param would allow the factory to instance multiple linkers from a single properties file. What you propose will work of course, but essentially every linker would need a properties file just to instance itself, and at this point the factory is almost pointless, why not just instance the class directly and bypass the factory all together?

> Entity linker factory should not require the "entity type" parameter
> --------------------------------------------------------------------
>
>                 Key: OPENNLP-653
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-653
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Entity Linker
>            Reporter: Joern Kottmann
>            Assignee: Mark Giaconia
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> The current implementation of the Entity Linker Factory requires the caller to pass in the entity type. This parameter, if needed, should be stored inside the passed in properties.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)