You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jackye1995 (via GitHub)" <gi...@apache.org> on 2023/02/05 01:16:24 UTC
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6746: AWS: Load HttpClientBuilder dynamically to avoid runtime deps of both urlconnection and apache client
jackye1995 commented on code in PR #6746:
URL: https://github.com/apache/iceberg/pull/6746#discussion_r1096607340
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -366,36 +362,48 @@ public class AwsProperties implements Serializable {
*/
public static final String HTTP_CLIENT_TYPE_URLCONNECTION = "urlconnection";
+ /**
+ * The prefix for configurations of for {@link
+ * software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.Builder}
+ */
+ public static final String HTTP_CLIENT_URLCONNECTION_PREFIX = "http-client.urlconnection.";
+
/**
* If this is set under {@link #HTTP_CLIENT_TYPE}, {@link
* software.amazon.awssdk.http.apache.ApacheHttpClient} will be used as the HTTP Client in {@link
* AwsClientFactory}
*/
public static final String HTTP_CLIENT_TYPE_APACHE = "apache";
+ /**
+ * The prefix for configurations of for {@link
+ * software.amazon.awssdk.http.apache.ApacheHttpClient.Builder}
+ */
+ public static final String HTTP_CLIENT_APACHE_PREFIX = "http-client.apache.";
+
public static final String HTTP_CLIENT_TYPE_DEFAULT = HTTP_CLIENT_TYPE_URLCONNECTION;
/**
* Used to configure the connection timeout in milliseconds for {@link
- * UrlConnectionHttpClient.Builder}. This flag only works when {@link #HTTP_CLIENT_TYPE} is set to
- * {@link #HTTP_CLIENT_TYPE_URLCONNECTION}
+ * software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient.Builder}. This flag only
+ * works when {@link #HTTP_CLIENT_TYPE} is set to {@link #HTTP_CLIENT_TYPE_URLCONNECTION}
*
* <p>For more details, see
* https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/http/urlconnection/UrlConnectionHttpClient.Builder.html
*/
public static final String HTTP_CLIENT_URLCONNECTION_CONNECTION_TIMEOUT_MS =
- "http-client.urlconnection.connection-timeout-ms";
+ HTTP_CLIENT_URLCONNECTION_PREFIX + HttpClientConfigurations.CONNECTION_TIMEOUT_MS;
Review Comment:
I remember we preferred to use the full config name because it is easier for people to search for it in the codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org