[jira] [Commented] (AIRFLOW-5441) When you force pull images with Breeze it rebuilds npm unnecessarily

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925324#comment-16925324 ] 

ASF GitHub Bot commented on AIRFLOW-5441:
-----------------------------------------

potiuk commented on pull request #6061: [AIRFLOW-5441] Ownership of package*.json file group write is fixed
URL: https://github.com/apache/airflow/pull/6061
 
 
   When you use Breeze and you specify "--force-pull" flag, the latest image from
   DockerHub is pulled before you attempt to rebuild the image. Currently in
   breeze we used an optimised version of "fix-permission" script that only fixes
   permissions of several files in the context (the workaround for different
   roup write umask setting in DockerHub). However we did not have package.json
   and package-lock.json on the list so those files were always seen as "changed"
   and npm was reinstalled for the first time (and only the first time) when the
   image was force pulled.
   
   After fixing this, the of --force-pull breeze commands will be much faster -
   skipping the whole npm package reinstallation. Depending on your network speed,
   this might be between 20 seconds to several minutes as npm ci command wipes out
   everything and downloads a lot of packages.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5441
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> When you force pull images with Breeze it rebuilds npm unnecessarily
> --------------------------------------------------------------------
>
>                 Key: AIRFLOW-5441
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5441
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.6
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> When you use Breeze and you specify "--force-pull" flag, the latest image from DockerHub is pulled before you attempt to rebuild the image. Currently in breeze we used an optimised version of "fix-permission" script that only fixes permissions of several files in the context (the workaround for different (group write) umask setting in DockerHub). However we did not have package.json and package-lock.json on the list so those files were always seen as "changed" and npm was reinstalled for the first time (and only the first time) when the image was force pulled.
>  
> After fixing this, the of --force-pull breeze commands will be much faster - skipping the whole npm package reinstallation. Depending on your network speed, this might be between 20 seconds to several minutes as npm ci command wipes out everything and downloads a lot of packages.
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)