You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2023/06/28 10:55:03 UTC
[GitHub] [camel] oscerd opened a new pull request, #10534: CAMEL-19279 - Azure Storage Files component for Camel 4.x
oscerd opened a new pull request, #10534:
URL: https://github.com/apache/camel/pull/10534
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10534: CAMEL-19279 - Azure Storage Files component for Camel 4.x
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10534:
URL: https://github.com/apache/camel/pull/10534#issuecomment-1611947865
`org.apache.camel.catalog.CamelCatalogJsonSchemaTest` is failing after this PR:
```
cd catalog/camel-catalog
mvnd test -Dtest=CamelCatalogJsonSchemaTest
...
[ERROR] org.apache.camel.catalog.CamelCatalogJsonSchemaTest.testValidateJsonComponent -- Time elapsed: 0.039 s <<< FAILURE!
org.opentest4j.AssertionFailedError: Component azure-files. Syntax azure-files://account[.host]/share[/dir]. Part account[ is not defined as UriPath ==> expected: <true> but was: <false>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:211)
at org.apache.camel.catalog.CamelCatalogJsonSchemaTest.validateComponentSyntax(CamelCatalogJsonSchemaTest.java:95)
at org.apache.camel.catalog.CamelCatalogJsonSchemaTest.testValidateJsonComponent(CamelCatalogJsonSchemaTest.java:58)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #10534: CAMEL-19279 - Azure Storage Files component for Camel 4.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #10534:
URL: https://github.com/apache/camel/pull/10534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10534: CAMEL-19279 - Azure Storage Files component for Camel 4.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10534:
URL: https://github.com/apache/camel/pull/10534#issuecomment-1611221740
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10534: CAMEL-19279 - Azure Storage Files component for Camel 4.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10534:
URL: https://github.com/apache/camel/pull/10534#issuecomment-1611190214
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10534: CAMEL-19279 - Azure Storage Files component for Camel 4.x
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10534:
URL: https://github.com/apache/camel/pull/10534#issuecomment-1611221767
### Core test results:
| Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- |
| 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10534: CAMEL-19279 - Azure Storage Files component for Camel 4.x
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10534:
URL: https://github.com/apache/camel/pull/10534#issuecomment-1611960236
Thanks for that. Will fix it on Friday
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org