[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1545: [core][hive] Support syncing partition into Hive metastore when using Hive catalog

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #1545:
URL: https://github.com/apache/incubator-paimon/pull/1545#discussion_r1260613763


##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -755,6 +755,15 @@ public class CoreOptions implements Serializable {
                             "Parameter string for the constructor of class #. "
                                     + "Callback class should parse the parameter by itself.");
 
+    public static final ConfigOption<Boolean> PARTITION_ADD_TO_METASTORE =
+            key("partition.add-to-metastore")

Review Comment:
   I have a feeling that what is actually being said here is that we will synchronize paimon's partition table into Hive's partition table, and after synchronization, of course, we need to addPartition.
   
   So this key better say create hive partitioned table?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org