You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/08/18 12:21:28 UTC
[GitHub] tajo pull request: TAJO-1781: Large-scale overhead is occured.
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/698
TAJO-1781: Large-scale overhead is occured.
The problem is some hard code in CommonConditionReduceRule.
I've fixed this problem and added more tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1781
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #698
----
commit 3a88521086504e237ca7a27529ce5ac8605e5614
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-18T10:19:40Z
Improved CommonConditionReduceRule
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1781: Join condition is still not found wh...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/698#issuecomment-132611965
Thanks. I've fixed comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1781: Join condition is still not found wh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1781: Join condition is still not found wh...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/698#issuecomment-132614267
+1
The patch looks good to me, and the examples included in comments look comprehensive. Also, the unit tests are enough to verify this feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1781: Join condition is still not found wh...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/698#discussion_r37408675
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/CommonConditionReduceRule.java ---
@@ -162,58 +162,72 @@ protected EvalNode visitDefaultFunctionEval(Object context, Stack<EvalNode> stac
private EvalNode rewrite(BinaryEval evalNode) {
// Example qual: ( a | b ) ^ ( a | c )
--- End diff --
Even through it is not change in this patch, it would be great if you change it to more intuitive example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---