You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/05 11:14:00 UTC
[jira] [Commented] (IMAGING-154) Remove Debug class
[ https://issues.apache.org/jira/browse/IMAGING-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352262#comment-16352262 ]
ASF GitHub Bot commented on IMAGING-154:
----------------------------------------
GitHub user kinow opened a pull request:
https://github.com/apache/commons-imaging/pull/35
IMAGING-154 Removed Debug class
Removed the `Debug` and `ImageDump` classes. Also removed methods with the `verbose` parameter, as well as any `System.out.println`'s. Tried to keep the change to a minimum, but given the extent of its use, I believe the pull request diff will be a bit long.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kinow/commons-imaging IMAGING-154
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-imaging/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit 0e218c63086ce0e0ee9270d6099cc9466a0cda4c
Author: Bruno P. Kinoshita <br...@...>
Date: 2018-02-05T11:10:25Z
IMAGING-154 Removed Debug class
----
> Remove Debug class
> ------------------
>
> Key: IMAGING-154
> URL: https://issues.apache.org/jira/browse/IMAGING-154
> Project: Commons Imaging
> Issue Type: Task
> Affects Versions: Patch Needed
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Fix For: 1.0
>
>
> Low level libraries should not do logging, but communicate through the use of exceptions and meaningful return values. Remove the Debug class and all it's uses.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)