[GitHub] [incubator-doris] imay commented on a change in pull request #1907: Make batchEndId default value to zero instead

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1907: Make batchEndId default value to zero instead
URL: https://github.com/apache/incubator-doris/pull/1907#discussion_r329141699
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/transaction/TransactionIdGenerator.java
 ##########
 @@ -30,7 +30,7 @@
     
     private long nextId = NEXT_ID_INIT_VALUE;
     // has to set it to an invalid value, then it will be logged when id is firstly increment
-    private long batchEndId = -1;
+    private long batchEndId = 0;
 
 Review comment:
   Does it work? nextId starts with NEXT_ID_INIT_VALUE, which is 1000. How can 0 be generated?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org