You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/06/26 07:28:51 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #974: Submarine 1287. Experiment codes refactoring
cdmikechen opened a new pull request, #974:
URL: https://github.com/apache/submarine/pull/974
### What is this PR for?
Based on the modified refactored notebook codes, the experiment codes are also need to be refactored.
### What type of PR is it?
Refactoring
### Todos
* [x] - Experiment codes refactoring in K8sSubmitter
* [ ] - Add experiment test cases
* [x] - Fix some test cases error
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1287
### How should this be tested?
Add experiment test cases
### Screenshots (if appropriate)
No
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? Yes
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #974: [WIP] Submarine 1287. Experiment codes refactoring
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #974:
URL: https://github.com/apache/submarine/pull/974#issuecomment-1193126192
# [Codecov](https://codecov.io/gh/apache/submarine/pull/974?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#974](https://codecov.io/gh/apache/submarine/pull/974?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5401e2a) into [master](https://codecov.io/gh/apache/submarine/commit/e4df9741a547dd8aae3058863f35529c88fa62ca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4df974) will **decrease** coverage by `0.02%`.
> The diff coverage is `1.09%`.
```diff
@@ Coverage Diff @@
## master #974 +/- ##
===========================================
- Coverage 9.18% 9.15% -0.03%
Complexity 670 670
===========================================
Files 234 235 +1
Lines 23716 23782 +66
Branches 3475 3470 -5
===========================================
Hits 2178 2178
- Misses 21407 21472 +65
- Partials 131 132 +1
```
| [Impacted Files](https://codecov.io/gh/apache/submarine/pull/974?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ubmarine/commons/utils/SubmarineConfiguration.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLWNvbW1vbnMvY29tbW9ucy11dGlscy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3VibWFyaW5lL2NvbW1vbnMvdXRpbHMvU3VibWFyaW5lQ29uZmlndXJhdGlvbi5qYXZh) | `35.19% <0.00%> (-0.40%)` | :arrow_down: |
| [...ine/server/api/exception/InvalidSpecException.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvc2VydmVyL2FwaS9leGNlcHRpb24vSW52YWxpZFNwZWNFeGNlcHRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ache/submarine/server/api/spec/ExperimentMeta.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zdWJtYXJpbmUvc2VydmVyL2FwaS9zcGVjL0V4cGVyaW1lbnRNZXRhLmphdmE=) | `40.90% <0.00%> (-5.25%)` | :arrow_down: |
| [...e/submarine/server/submitter/k8s/K8sSubmitter.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9LOHNTdWJtaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...submarine/server/submitter/k8s/model/AgentPod.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9tb2RlbC9BZ2VudFBvZC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...marine/server/submitter/k8s/model/mljob/MLJob.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9tb2RlbC9tbGpvYi9NTEpvYi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...server/submitter/k8s/model/mljob/MLJobFactory.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9tb2RlbC9tbGpvYi9NTEpvYkZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...er/submitter/k8s/model/mljob/MLJobReplicaSpec.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9tb2RlbC9tbGpvYi9NTEpvYlJlcGxpY2FTcGVjLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ver/submitter/k8s/model/pytorchjob/PyTorchJob.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9tb2RlbC9weXRvcmNoam9iL1B5VG9yY2hKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...submitter/k8s/model/pytorchjob/PyTorchJobSpec.java](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNlcnZlci9zZXJ2ZXItc3VibWl0dGVyL3N1Ym1pdHRlci1rOHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N1Ym1hcmluZS9zZXJ2ZXIvc3VibWl0dGVyL2s4cy9tb2RlbC9weXRvcmNoam9iL1B5VG9yY2hKb2JTcGVjLmphdmE=) | `0.00% <ø> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/submarine/pull/974/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #974: [WIP] Submarine 1287. Experiment codes refactoring
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on PR #974:
URL: https://github.com/apache/submarine/pull/974#issuecomment-1173598117
@xunliu
Oh sorry. This PR conflicts with PR https://github.com/apache/submarine/pull/939 , I need to rebase the codes later to continue. So I add [WIP], and there are still some test cases that need to be added.
I will delete [WIP] after all the problems were solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #974: SUBMARINE-1287. Experiment codes refactoring
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #974: SUBMARINE-1287. Experiment codes refactoring
URL: https://github.com/apache/submarine/pull/974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] xunliu commented on pull request #974: [WIP] Submarine 1287. Experiment codes refactoring
Posted by GitBox <gi...@apache.org>.
xunliu commented on PR #974:
URL: https://github.com/apache/submarine/pull/974#issuecomment-1173089136
hi, @cdmikechen
Maybe need change PR title to `SUBMARINE-1287. Experiment codes refactoring` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org