You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/21 08:10:20 UTC

[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #168: [DRAFT] upgrade protobuf-java

pjfanning commented on code in PR #168:
URL: https://github.com/apache/incubator-pekko-grpc/pull/168#discussion_r1299768549


##########
project/Dependencies.scala:
##########
@@ -36,7 +36,7 @@ object Dependencies {
     // If changing this, remember to update protoc plugin version to align in
     // maven-plugin/src/main/maven/plugin.xml and org.apache.pekko.grpc.sbt.PekkoGrpcPlugin
     val googleProtoc = "3.20.1" // checked synced by VersionSyncCheckPlugin

Review Comment:
   This is due to https://github.com/apache/incubator-pekko-grpc/pull/117 
   
   There are changes in newer versions of protoc that break Pekko build. That doesn't stop using from using newer versions of protobuf-java.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org