You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/06/26 23:23:45 UTC
[jira] Created: (THRIFT-65) Enabling 64-bit integer constants
Enabling 64-bit integer constants
---------------------------------
Key: THRIFT-65
URL: https://issues.apache.org/jira/browse/THRIFT-65
Project: Thrift
Issue Type: Improvement
Components: Compiler (General)
Reporter: David Reiss
Assignee: David Reiss
Attachments: 0001-Partial-handlling-of-64-bit-integer-constants.patch
The Thrift compiler currently parses integer constants as 32-bit numbers. This patch allows 64-bit numbers to be used, but it does not verify that the individual language generators handle them properly. What would you all think about committing this? Should we include a warning until we verify that all of the generators handle 64-bit numbers properly (or at least fail safely)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-65) Enabling 64-bit integer constants
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-65:
------------------------------
Attachment: 0001-Partial-handlling-of-64-bit-integer-constants.patch
> Enabling 64-bit integer constants
> ---------------------------------
>
> Key: THRIFT-65
> URL: https://issues.apache.org/jira/browse/THRIFT-65
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: David Reiss
> Assignee: David Reiss
> Attachments: 0001-Partial-handlling-of-64-bit-integer-constants.patch
>
>
> The Thrift compiler currently parses integer constants as 32-bit numbers. This patch allows 64-bit numbers to be used, but it does not verify that the individual language generators handle them properly. What would you all think about committing this? Should we include a warning until we verify that all of the generators handle 64-bit numbers properly (or at least fail safely)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-65) Enabling 64-bit integer constants
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-65:
------------------------------
Attachment: int64-squash.patch
What would you think about committing after squashing this in?
> Enabling 64-bit integer constants
> ---------------------------------
>
> Key: THRIFT-65
> URL: https://issues.apache.org/jira/browse/THRIFT-65
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-Partial-handlling-of-64-bit-integer-constants.patch, int64-squash.patch
>
>
> The Thrift compiler currently parses integer constants as 32-bit numbers. This patch allows 64-bit numbers to be used, but it does not verify that the individual language generators handle them properly. What would you all think about committing this? Should we include a warning until we verify that all of the generators handle 64-bit numbers properly (or at least fail safely)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-65) Enabling 64-bit integer constants
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-65.
-------------------------------
Resolution: Fixed
Still doesn't work with C++, but that's a separate issue.
> Enabling 64-bit integer constants
> ---------------------------------
>
> Key: THRIFT-65
> URL: https://issues.apache.org/jira/browse/THRIFT-65
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-Partial-handlling-of-64-bit-integer-constants.patch, int64-squash.patch
>
>
> The Thrift compiler currently parses integer constants as 32-bit numbers. This patch allows 64-bit numbers to be used, but it does not verify that the individual language generators handle them properly. What would you all think about committing this? Should we include a warning until we verify that all of the generators handle 64-bit numbers properly (or at least fail safely)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-65) Enabling 64-bit integer constants
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609356#action_12609356 ]
Kevin Clark commented on THRIFT-65:
-----------------------------------
Works for me. We should probably have a wiki page as well, which explains which bindings do and don't have support.
Might be nice to have a matrix of features in general, but that's a different topic.
> Enabling 64-bit integer constants
> ---------------------------------
>
> Key: THRIFT-65
> URL: https://issues.apache.org/jira/browse/THRIFT-65
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-Partial-handlling-of-64-bit-integer-constants.patch, int64-squash.patch
>
>
> The Thrift compiler currently parses integer constants as 32-bit numbers. This patch allows 64-bit numbers to be used, but it does not verify that the individual language generators handle them properly. What would you all think about committing this? Should we include a warning until we verify that all of the generators handle 64-bit numbers properly (or at least fail safely)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-65) Enabling 64-bit integer constants
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609362#action_12609362 ]
David Reiss commented on THRIFT-65:
-----------------------------------
Sorry, I forgot to put the issue number in the commit message. This was fixed by r672907.
> Enabling 64-bit integer constants
> ---------------------------------
>
> Key: THRIFT-65
> URL: https://issues.apache.org/jira/browse/THRIFT-65
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-Partial-handlling-of-64-bit-integer-constants.patch, int64-squash.patch
>
>
> The Thrift compiler currently parses integer constants as 32-bit numbers. This patch allows 64-bit numbers to be used, but it does not verify that the individual language generators handle them properly. What would you all think about committing this? Should we include a warning until we verify that all of the generators handle 64-bit numbers properly (or at least fail safely)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-65) Enabling 64-bit integer constants
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-65:
------------------------------
Priority: Minor (was: Major)
> Enabling 64-bit integer constants
> ---------------------------------
>
> Key: THRIFT-65
> URL: https://issues.apache.org/jira/browse/THRIFT-65
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-Partial-handlling-of-64-bit-integer-constants.patch
>
>
> The Thrift compiler currently parses integer constants as 32-bit numbers. This patch allows 64-bit numbers to be used, but it does not verify that the individual language generators handle them properly. What would you all think about committing this? Should we include a warning until we verify that all of the generators handle 64-bit numbers properly (or at least fail safely)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-65) Enabling 64-bit integer constants
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608905#action_12608905 ]
Kevin Clark commented on THRIFT-65:
-----------------------------------
Ruby should be ok, but I agree we should warn until there's uniformity across the libraries.
> Enabling 64-bit integer constants
> ---------------------------------
>
> Key: THRIFT-65
> URL: https://issues.apache.org/jira/browse/THRIFT-65
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-Partial-handlling-of-64-bit-integer-constants.patch
>
>
> The Thrift compiler currently parses integer constants as 32-bit numbers. This patch allows 64-bit numbers to be used, but it does not verify that the individual language generators handle them properly. What would you all think about committing this? Should we include a warning until we verify that all of the generators handle 64-bit numbers properly (or at least fail safely)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.