You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "hemasrishalini (via GitHub)" <gi...@apache.org> on 2026/05/15 17:09:30 UTC

[PR] Refactor download logic in setup.sh into a shared helper function [polaris]

hemasrishalini opened a new pull request, #4458:
URL: https://github.com/apache/polaris/pull/4458

   Summary
   
   Extracts a shared download_if_missing helper to eliminate repeated wget + brew fallback logic.
   
   Also fixes a partial-download edge case where failed downloads leave zero-byte files that incorrectly satisfy existence checks.
   
   Testing
   
   Ran:
   
   bash -n regtests/setup.sh
   
   ## Checklist
   - [ ] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [ ] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [ ] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] 💡 Added comments for complex logic
   - [ ] 🧾 Updated `CHANGELOG.md` (if needed)
   - [ ] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor download logic in setup.sh into a shared helper function [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.

dimas-b merged PR #4458:
URL: https://github.com/apache/polaris/pull/4458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor download logic in setup.sh into a shared helper function [polaris]

Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.

MonkeyCanCode commented on PR #4458:
URL: https://github.com/apache/polaris/pull/4458#issuecomment-4468448950

   Looks good to me. Thanks for the contribution @hemasrishalini 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org