You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/17 18:58:37 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
dongjoon-hyun opened a new pull request #29793:
URL: https://github.com/apache/spark/pull/29793
### What changes were proposed in this pull request?
The PR aims to add Scala 2.13 build test coverage into GitHub Action for Apache Spark 3.1.0.
### Why are the changes needed?
The branch is ready for Scala 2.13 and this will prevent any regression.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the GitHub Action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694437210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29793:
URL: https://github.com/apache/spark/pull/29793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694530389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-701654418
Please file a JIRA for creating Scala 2.13 Jenkins job. I guess we don't have enough resource for Scala 2.13 full testing inside GitHub Action, @LuciferYang .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694436416
**[Test build #128839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128839/testReport)** for PR 29793 at commit [`f52385c`](https://github.com/apache/spark/commit/f52385cc38a73b6df169599b927c352a67f17015).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694436390
cc @srowen and @HyukjinKwon .
I dropped my PR (for `core` module) previously, but `master` branch seems to be almost ready for Scala 2.13 now. So, I'm trying another try to enforce this in GitHub Action. Since the full testing is almost ready, and I hope we can add Jenkins job for Scala 2.13 for Apache Spark 3.1.0.
- https://github.com/apache/spark/pull/29312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694436416
**[Test build #128839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128839/testReport)** for PR 29793 at commit [`f52385c`](https://github.com/apache/spark/commit/f52385cc38a73b6df169599b927c352a67f17015).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694577355
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694530389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-701886586
@dongjoon-hyun ok ~ I will do it later, on holiday now :) EDIT: SPARK-33044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694497733
Thank you, @srowen ! Merged to master for Apache Spark 3.1.0 on December 2020.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694436390
cc @srowen and @HyukjinKwon .
I dropped [my PR (for `core` module)](https://github.com/apache/spark/pull/29312) previously, but `master` branch seems to be almost ready for Scala 2.13 now. So, I'm doing another try to enforce this in GitHub Action. Since the full testing is almost ready, and I hope we can add Jenkins job for Scala 2.13 for Apache Spark 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694529308
**[Test build #128839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128839/testReport)** for PR 29793 at commit [`f52385c`](https://github.com/apache/spark/commit/f52385cc38a73b6df169599b927c352a67f17015).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694437210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694436390
cc @srowen and @HyukjinKwon .
I dropped [my PR (for `core` module)](https://github.com/apache/spark/pull/29312) previously, but `master` branch seems to be almost ready for Scala 2.13 now. So, I'm trying another try to enforce this in GitHub Action. Since the full testing is almost ready, and I hope we can add Jenkins job for Scala 2.13 for Apache Spark 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-701886586
@dongjoon-hyun ok ~ I will do it later, on holiday now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-694600774
Thanks, @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #29793: [SPARK-32926][TESTS] Add Scala 2.13 build test in GitHub Action
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #29793:
URL: https://github.com/apache/spark/pull/29793#issuecomment-701354557
@dongjoon-hyun do we want to put the full testing of Scala 2.13 into GitHub Action or Jenkins job ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org