You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2018/08/28 16:43:00 UTC
[jira] [Commented] (KYLIN-3482) Unclosed
SetAndUnsetThreadLocalConfig in SparkCubingByLayer
[ https://issues.apache.org/jira/browse/KYLIN-3482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595265#comment-16595265 ]
Ted Yu commented on KYLIN-3482:
-------------------------------
Some more occurrences of calling KylinConfig.setAndUnsetThreadLocalConfig without closing:
engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkFactDistinct.java
> Unclosed SetAndUnsetThreadLocalConfig in SparkCubingByLayer
> -----------------------------------------------------------
>
> Key: KYLIN-3482
> URL: https://issues.apache.org/jira/browse/KYLIN-3482
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: jiatao.tao
> Priority: Minor
> Fix For: v2.5.0
>
>
> Here is related code:
> {code}
> KylinConfig kylinConfig = AbstractHadoopJob.loadKylinConfigFromHdfs(sConf, metaUrl);
> KylinConfig.setAndUnsetThreadLocalConfig(kylinConfig);
> {code}
> The return value from setAndUnsetThreadLocalConfig should be closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)