[GitHub] [spark] srowen commented on a change in pull request #35426: [SPARK-38130][SQL] Remove array_sort orderable entries check

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #35426:
URL: https://github.com/apache/spark/pull/35426#discussion_r800736584



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -388,18 +388,13 @@ case class ArraySort(
     checkArgumentDataTypes() match {
       case TypeCheckResult.TypeCheckSuccess =>
         argument.dataType match {
-          case ArrayType(dt, _) if RowOrdering.isOrderable(dt) =>
+          case ArrayType(_, _) =>

Review comment:
       I don't know this code well, but is it possible to check it's orderable only if there is no lambda? or check if the lambda's result is orderable if present instead? It does make sense to not fail this case but just wondering if we can preserve a better error message




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org