[GitHub] [spark] tanelk commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions

[GitBox <gi...@apache.org>]

tanelk commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r504841966



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java
##########
@@ -40,8 +40,11 @@
     private String deprecated;
 
     private static final Set<String> validGroups =
-        new HashSet<>(Arrays.asList("agg_funcs", "array_funcs", "datetime_funcs",
-            "json_funcs", "map_funcs", "window_funcs"));
+        new HashSet<>(Arrays.asList("agg_funcs", "array_funcs", "binary_funcs", "bitwise_funcs",
+            "comparison_funcs", "conditional_funcs", "conversion_funcs", "csv_funcs",
+            "datetime_funcs", "generator_funcs", "grouping_funcs", "json_funcs", "logical_funcs",
+            "map_funcs", "math_funcs", "misc_funcs", "regex_funcs", "string_funcs", "struct_funcs",
+            "window_funcs", "xml_funcs"));

Review comment:
       I tried to follow the way [Presto](https://prestodb.io/docs/current/functions.html) has classified its functions, but all this is up for a change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org