You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/02/15 08:13:03 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #4425: fix(sonarqube): fix remote api
warren830 opened a new pull request, #4425:
URL: https://github.com/apache/incubator-devlake/pull/4425
### Summary
Fix remote api according to #4411
### Does this close any open issues?
part of #2305
### Screenshots
```shell
curl --request GET \
--url 'http://127.0.0.1:8080/plugins/sonarqube/connections/1/remote-scopes?pageToken=eyJwYWdlIjoyLCJwZXJfcGFnZSI6MTAsInRhZyI6IiJ9' \
--header 'content-type: multipart/form-data'
```
<img width="1071" alt="image" src="https://user-images.githubusercontent.com/39366025/218970069-ab0b1bad-4552-47a8-9fd2-974a03eb58b6.png">
```shell
curl --request GET \
--url 'http://127.0.0.1:8080/plugins/sonarqube/connections/1/search-remote-scopes?search=AndroidUtilCode' \
--header 'content-type: multipart/form-data'
```
<img width="1082" alt="image" src="https://user-images.githubusercontent.com/39366025/218970150-d409dc53-d312-4e5b-8514-48533075d97b.png">
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #4425: fix(sonarqube): fix remote api
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 merged PR #4425:
URL: https://github.com/apache/incubator-devlake/pull/4425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mappjzc commented on a diff in pull request #4425: fix(sonarqube): fix remote api
Posted by "mappjzc (via GitHub)" <gi...@apache.org>.
mappjzc commented on code in PR #4425:
URL: https://github.com/apache/incubator-devlake/pull/4425#discussion_r1106790665
##########
backend/plugins/sonarqube/api/remote.go:
##########
@@ -60,8 +67,8 @@ const TypeProject string = "scope"
// @Tags plugins/sonarqube
// @Accept application/json
// @Param connectionId path int false "connection ID"
-// @Param pageToken body string false "page Token"
-// @Success 200 {object} []models.SonarqubeProject
+// @Param pageToken query string false "page Token"
+// @Success 200 {object} []RemoteScopesOutput
Review Comment:
here not need []
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org