[GitHub] [pulsar] Jason918 commented on a change in pull request #14327: [Transaction] Fix individual ack batch message with transaction abort redevlier duplicate messages

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #14327:
URL: https://github.com/apache/pulsar/pull/14327#discussion_r835703859



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/PositionAckSetUtil.java
##########
@@ -46,12 +46,18 @@ public static void andAckSet(PositionImpl currentPosition, PositionImpl otherPos
         if (currentPosition == null || otherPosition == null) {
             return;
         }
-        BitSetRecyclable thisAckSet = BitSetRecyclable.valueOf(currentPosition.getAckSet());
-        BitSetRecyclable otherAckSet = BitSetRecyclable.valueOf(otherPosition.getAckSet());
+        currentPosition.setAckSet(andAckSet(currentPosition.getAckSet(), otherPosition.getAckSet()));
+    }
+
+    //This method is do `or` operation for ack set

Review comment:
       ```suggestion
       //This method is do `and` operation for ack set
   ```
   Typo?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org