You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/27 17:16:54 UTC
[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #134:
[WIP] IP Ranges form component for Public,
Management and Storage traffic types
RitchieVincent opened a new pull request #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types
URL: https://github.com/apache/cloudstack-primate/pull/134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #134: [WIP]
IP Ranges form component for Public, Management and Storage traffic types
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types
URL: https://github.com/apache/cloudstack-primate/pull/134#issuecomment-581988291
> @RitchieVincent for the public network IP range, can you show the domain/account reservation form in the main modal itself than the modal-in-a-modal format:
>
> 
>
> For example, use a radio button to show/hide whether admin wants reservation or not.
That's sorted now in the latest updates to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #134: IP Ranges form
component for Public, Management and Storage traffic types
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #134: IP Ranges form component for Public, Management and Storage traffic types
URL: https://github.com/apache/cloudstack-primate/pull/134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #134: [WIP] IP Ranges
form component for Public, Management and Storage traffic types
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types
URL: https://github.com/apache/cloudstack-primate/pull/134#issuecomment-582769598
@RitchieVincent can you make use of `a-table` with pagination in this PR as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #134: [WIP]
IP Ranges form component for Public, Management and Storage traffic types
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types
URL: https://github.com/apache/cloudstack-primate/pull/134#issuecomment-582898781
> @RitchieVincent can you make use of `a-table` with pagination in this PR as well?
That's complete now in the latest PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] RitchieVincent commented on issue #134: [WIP]
IP Ranges form component for Public, Management and Storage traffic types
Posted by GitBox <gi...@apache.org>.
RitchieVincent commented on issue #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types
URL: https://github.com/apache/cloudstack-primate/pull/134#issuecomment-579240280
@rhtyd Quick note about this, I had to change the vertical nav links to horizontal cards, as they would not display on mobile nicely. This also had the added benefit of allowing more width in the display area.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #134: [WIP] IP Ranges
form component for Public, Management and Storage traffic types
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #134: [WIP] IP Ranges form component for Public, Management and Storage traffic types
URL: https://github.com/apache/cloudstack-primate/pull/134#issuecomment-581385344
@RitchieVincent for the public network IP range, can you show the domain/account reservation form in the main modal itself than the modal-in-a-modal format:
For example, use a radio button to show/hide whether admin wants reservation or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services