You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Zoltan Chovan (Code Review)" <ge...@cloudera.org> on 2025/04/10 14:27:47 UTC
[kudu-CR] [WIP] KUDU-3657 - fix publishing
Zoltan Chovan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22768
Change subject: [WIP] KUDU-3657 - fix publishing
......................................................................
[WIP] KUDU-3657 - fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadown
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
TODO:
[] manual check of generated POMs for all Java modules
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/1
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the implementation and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the compileUnshaded configuration to be extending the
compileOnly configuration. This was necessary to correct the scope of
these dependencies. This change also made it necessary to add the
compileUnshaded dependencies explicitly to the test compile path as
well[0].
[0] https://blog.gradle.org/introducing-compile-only-dependencies
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Reviewed-on: http://gerrit.cloudera.org:8080/22768
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-test-utils/build.gradle
9 files changed, 112 insertions(+), 34 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 25
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 24: Verified+1
Unrelated build failures.
Abhishek verified that PS24 produces proper JAR artifacts.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jun 2025 01:11:15 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 17:14:38 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Removed Code-Review+1 by Abhishek Chennaka <ac...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 10
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#21).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the implementation and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the compileUnshaded configuration to be extending the
compileOnly configuration. This was necessary to correct the scope of
these dependencies. This change also made it necessary to add the
compileUnshaded dependencies explicitly to the test compile path as
well[0].
[0] https://blog.gradle.org/introducing-compile-only-dependencies
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
12 files changed, 217 insertions(+), 165 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/21
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 21
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 13:
> Patch Set 13: Verified-1
>
> Build Failed
>
> http://jenkins.kudu.apache.org/job/pre_commit/1331/ : FAILURE
Failed tests seem unrelated (flaky tests)
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 11:19:44 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: KUDU-3657 - fix publishing
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1286/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 13:34:47 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] KUDU-3657 - fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#2).
Change subject: [WIP] KUDU-3657 - fix publishing
......................................................................
[WIP] KUDU-3657 - fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadown
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
TODO:
[] manual check of generated POMs for all Java modules
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-subprocess/build.gradle
5 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/2
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#10).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
8 files changed, 31 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/10
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 10
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 9:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1297/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 10:13:13 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22768/7//COMMIT_MSG@12
PS7, Line 12: shadown
shadow
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 17:37:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 20:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1406/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 20
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 18:28:18 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 14:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1338/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 14
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 12:52:02 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 15: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1342/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 15
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 06:59:27 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 21:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:
PS21:
Here and in kudu-hive, are we leaning towards shading the dependencies like before the Gradle upgrade, looks like. In that case do we know why these were excluded in the first place during the Gradle upgrade?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 21
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jun 2025 18:17:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/10//COMMIT_MSG
Commit Message:
PS10:
I downloaded the patch, applied it on top of the main branch, and ran `./gradlew clean -Dmaven.repo.local=<localRepoPath> publishToMavenLocal` from the $KUDU_HOME directory.
I took a look at the generated kudu-client-1.18.0-SNAPSHOT.pom file. It contains the following:
<dependencies>
<dependency>
<groupId>org.apache.kudu</groupId>
<artifactId>kudu-proto</artifactId>
<version>1.18.0-SNAPSHOT</version>
<scope>runtime</scope>
<exclusions>
<exclusion>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_annotations</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.j2objc</groupId>
<artifactId>j2objc-annotations</artifactId>
</exclusion>
<exclusion>
<groupId>org.checkerframework</groupId>
<artifactId>checker-compat-qual</artifactId>
</exclusion>
<exclusion>
<groupId>org.codehaus.mojo</groupId>
<artifactId>animal-sniffer-annotations</artifactId>
</exclusion>
</exclusions>
</dependency>
...
<dependencies>
Since we are not publishing kudu-proto artifact, how is the dependency resolution is supposed to work for a Kudu client Java application that uses kudu-client? The generated POM file states that kudu-client needs kudu-proto in runtime, so how is the application built outside of $KUDU_HOME is going to run? I'm not sure I understand this, but I might be missing some crucial details here.
Could you shed some light on this, please?
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 10
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Apr 2025 18:41:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#12).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
9 files changed, 32 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/12
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 14:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22768/14//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22768/14//COMMIT_MSG@31
PS14, Line 31: implamentation
nit: implementation
http://gerrit.cloudera.org:8080/#/c/22768/14/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/14/java/kudu-spark/build.gradle@18
PS14, Line 18: apply plugin: "maven-publish"
Why is this plugin needed?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 14
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 06:08:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 16: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1344/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 16
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 08:15:20 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] KUDU-3657 - fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [WIP] KUDU-3657 - fix publishing
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1284/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Apr 2025 15:23:52 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 21:
(2 comments)
compileUnshaded still results in a runtime scoped dependency, will have to take another go to resolve that
http://gerrit.cloudera.org:8080/#/c/22768/20/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/20/java/gradle/shadow.gradle@65
PS20, Line 65: e
> Remove the stray space?
Done
http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup-tools/build.gradle
File java/kudu-backup-tools/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup-tools/build.gradle@49
PS19, Line 49: testImplementation project(path: ":kudu-backup-commo
> Is this a duplicate for the directive at line 38 above?
yes, resolved
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 21
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 14:48:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: KUDU-3657 - fix publishing
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1287/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 14:40:25 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 8: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1290/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 18:39:23 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 21:
(3 comments)
Please re-base this patch on the top of the main branch: gerrit reports on conflicts as of PS21, so even if this patch were ready to go, we wouldn't be able to merge it.
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-backup-tools/build.gradle
File java/kudu-backup-tools/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-backup-tools/build.gradle@38
PS21, Line 38: // testCompileOnly project(path: ":kudu-backup-common")
nit: remove the commented line?
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-client/build.gradle
File java/kudu-client/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-client/build.gradle@47
PS21, Line 47: libs.jsr305
It's not related to this changelist, but overall migration off from jsr305 is long overdue. Many other project migrated away from jsr305 annotations, with just a few notable ones:
* https://github.com/google/guava/issues/2960
* https://github.com/ben-manes/caffeine/issues/337
It seems CheckerFramework and Jetbrains annotations among the most viable alternatives. Anyway, since many other project moved away from jsr305 a few years ago, we can take a look, analyze that, and find the best alternative for the Kudu project.
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-test-utils/build.gradle@60
PS21, Line 60: compileOnlyApi libs.jsr305
: compileOnly libs.yetusAnnotations
I was looking at https://docs.gradle.org/current/userguide/java_library_plugin.html while trying to make sense of this.
I'm curious why these seemingly similar libraries are of different dependency configurations/types. Does kudu-test-utils use some annotations from jsr305 that consumers of kudu-test-utils need as well, but not so for yetusAnnotations? That seems highly unlikely, so I just wanted to make sure this isn't a typo.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 21
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jun 2025 00:05:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 22:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1442/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 22
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jun 2025 15:44:44 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 24: Code-Review+2
Tested the newly published jars and found no issues:
- Impala can create a table and read/write to it
- Same with Spark3
- Tested backing up of Kudu tables and restoring with the new jars
- Tested table creation/renaming in Kudu are reflected in HMS database
Let's wait for a +2 from Alexey too before merging.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jun 2025 23:34:38 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#20).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the implementation and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the compileUnshaded configuration to be extending the
compileOnly configuration. This was necessary to correct the scope of
these dependencies. This change also made it necessary to add the
compileUnshaded dependencies explicitly to the test compile path as
well[0].
[0] https://blog.gradle.org/introducing-compile-only-dependencies
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
13 files changed, 198 insertions(+), 158 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/20
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 20
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 21:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1416/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 21
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 14:48:06 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] KUDU-3657 - fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [WIP] KUDU-3657 - fix publishing
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1284/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Apr 2025 14:27:53 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/7/java/gradle/publishing.gradle
File java/gradle/publishing.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/7/java/gradle/publishing.gradle@82
PS7, Line 82:
nit: remove the spaces?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 17:30:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: KUDU-3657 - fix publishing
......................................................................
Patch Set 5: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1288/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 14:50:18 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#7).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadown
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-subprocess/build.gradle
5 files changed, 21 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/7
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 10:
Jenkins failure seems unrelated, TestKuduClient failed with timeout
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 10
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 11:58:02 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 18:
> Patch Set 17:
>
> > > Patch Set 17:
> > >
> > > (1 comment)
> >
> > The main reason why many of the implementation scopes were changed
> > is that when declaring them as 'api' these dependencies are not
> > included in the generated pom.xml. This behaviour is a bit odd
> > though, as from the documentation:
> >
> > "Dependencies appearing in the api configurations will be
> > transitively exposed to consumers of the library, and as such will
> > appear on the compile classpath of consumers. Dependencies found in
> > the implementation configuration will, on the other hand, not be
> > exposed to consumers, and therefore not leak into the consumers'
> > compile classpath."
> >
> > Which seems to contradict the actual behavior of the
> > configurations. So just to reiterate: when declaring for example
> > "implementation libs.netty", then the netty dependency will be
> > included in the pom as runtime dependency. These dependencies were
> > not present at all before the gradle version upgrade (where the
> > scopes compile and runtime are removed from gradle), so after
> > discussing with Abhishek, we opted to switch to api since that
> > resolved the pom issue. You can check the document I shared earlier
> > about the pom differences, please note that the currently generated
> > pom is much different than the "post-update" is in the document,
> > that is basically after upgrade but before this patch.
> >
> > Maybe this is a discrepancy between gradle and maven scoping
> > behaviour. What do you think?
>
> I think that using 'api' dependency as a workaround to the observed behavior isn't quite a good idea because it's semantically incorrect.
>
> Apparently, there is something wrong with the dependencies after upgrading to Gradle 7.x, and one would think that a proper way of resolving that might be finding the root cause of the issue and addressing it. I guess it requires much deeper analysis of current dependencies, shading and publishing. Throwing in workarounds like using wrong type of dependency doesn't smell good, especially if the observed behavior contradicts the documentation -- it's just another signal that something is wrong. Simply put, doing two wrongs doesn't make it right.
>
> Unfortunately, I don't have a recipe for a fix at this time. I haven't taken deep enough look at the problem and I'm not an expert in Java/Gradle dependency management.
Thanks for the feedback Alexey! I spent some more time on figuring out the root of the issue. I created a bit of a sandbox repository to streamline the investigation a bit: https://github.com/zchovan/gradle_testing/tree/master feel free to mess around with it.
In summary, I messed up the pom editing logic. The weird behaviour was present because I used the api config instead of the implementation config to calculate what should be taken out of the poms. I changed that and also fixed another mistake I made in the gradle upgrade commit, relating the compileUnshaded configuration. That should also work correctly now, and as it was originally intended. I can separate this changelist into multiple if you think that would be easier to review and process.
With this latest patchset both the poms and the dependency scope declarations should be okay, but please let me know if you find that I missed something.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 11:33:55 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 18:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1367/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 11:23:18 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 24:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1454/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 12:38:02 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#14).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the scope of dependencies in the kudu-client module from
implamentation to api to avoid including them in the generated poms
unnecessarily.
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
12 files changed, 83 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/14
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 14
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 9: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1297/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 11:49:05 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 18: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1367/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 11:33:12 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 19:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1389/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 19
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 May 2025 12:57:25 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 19: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1389/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 19
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 May 2025 14:01:40 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 19:
> (3 comments)
>
> Looks better compared with PS18, just a few nits and questions
> left.
Hey Zoltan!
I recall you cited concerns of delaying the upstream Kudu 1.18.0 release when I requested a few trivial changes some time ago: https://gerrit.cloudera.org/#/c/22768/17//COMMIT_MSG@28
As of today, I see that's been one than one week since your latest activity on this patch dated back to May 22, 2025. I left some feedback on May 27, 2025, but I don't see any updates there either.
I'm curious what's the status of this patch as of May 30, 2025. Did you hit some roadblocks in revving this patch and maybe need some help there?
Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 19
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 May 2025 17:22:39 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 20: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1406/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 20
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 19:55:51 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 11:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1327/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 11
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 May 2025 12:06:38 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 11: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1327/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 11
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 May 2025 12:52:02 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 12: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1328/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 May 2025 13:31:19 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 14: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1340/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 14
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 18:43:13 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 17: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1360/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 May 2025 09:43:08 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 17:
> > Patch Set 17:
> >
> > (1 comment)
>
> The main reason why many of the implementation scopes were changed
> is that when declaring them as 'api' these dependencies are not
> included in the generated pom.xml. This behaviour is a bit odd
> though, as from the documentation:
>
> "Dependencies appearing in the api configurations will be
> transitively exposed to consumers of the library, and as such will
> appear on the compile classpath of consumers. Dependencies found in
> the implementation configuration will, on the other hand, not be
> exposed to consumers, and therefore not leak into the consumers'
> compile classpath."
>
> Which seems to contradict the actual behavior of the
> configurations. So just to reiterate: when declaring for example
> "implementation libs.netty", then the netty dependency will be
> included in the pom as runtime dependency. These dependencies were
> not present at all before the gradle version upgrade (where the
> scopes compile and runtime are removed from gradle), so after
> discussing with Abhishek, we opted to switch to api since that
> resolved the pom issue. You can check the document I shared earlier
> about the pom differences, please note that the currently generated
> pom is much different than the "post-update" is in the document,
> that is basically after upgrade but before this patch.
>
> Maybe this is a discrepancy between gradle and maven scoping
> behaviour. What do you think?
I think that using 'api' dependency as a workaround to the observed behavior isn't quite a good idea because it's semantically incorrect.
Apparently, there is something wrong with the dependencies after upgrading to Gradle 7.x, and one would think that a proper way of resolving that might be finding the root cause of the issue and addressing it. I guess it requires much deeper analysis of current dependencies, shading and publishing. Throwing in workarounds like using wrong type of dependency doesn't smell good, especially if the observed behavior contradicts the documentation -- it's just another signal that something is wrong. Simply put, doing two wrongs doesn't make it right.
Unfortunately, I don't have a recipe for a fix at this time. I haven't taken deep enough look at the problem and I'm not an expert in Java/Gradle dependency management.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 May 2025 20:52:02 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] KUDU-3657 - fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [WIP] KUDU-3657 - fix publishing
......................................................................
Patch Set 1:
Tested in my build machine, I was able to publish for all modules. But do we want to keep the dependencies listed same as jars published in the previous versions? For example for kudu-client module, I see dependencies are not identical to what they were in 1.17.1.
Not sure if I am missing something:
https://repo1.maven.org/maven2/org/apache/kudu/kudu-client/1.17.1/kudu-client-1.17.1.pom
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Apr 2025 06:21:12 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/8//COMMIT_MSG
Commit Message:
PS8:
One more question: with this patch, what's current list of dependencies (with their types) for, e.g., kudu-client?
For more context, I'm curious whether or not Impala folks will be able to build Impala with kudu-client JAR as expected.
I recall in there was some analysis that Joe McDonnell did for KUDU-3610 in this regard, so I'm curious what is the current picture there with this patch.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 21:12:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [WIP] KUDU-3657 - fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [WIP] KUDU-3657 - fix publishing
......................................................................
Patch Set 1:
Of course the Gradle version is updated but should that affect the list of dependencies?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Apr 2025 06:23:25 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#6).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadown
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-subprocess/build.gradle
5 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/6
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 13: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1331/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 May 2025 22:27:26 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#13).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the scope of dependencies in the kudu-client module from
implamentation to api to avoid including them in the generated poms
unnecessarily.
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
9 files changed, 36 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/13
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 16: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1351/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 16
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 20:16:32 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#15).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the scope of dependencies in the kudu-client module from
implementation to api to avoid including them in the generated poms
unnecessarily.
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
12 files changed, 82 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/15
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 15
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 15:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22768/14//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22768/14//COMMIT_MSG@31
PS14, Line 31: implementation
> nit: implementation
Done
http://gerrit.cloudera.org:8080/#/c/22768/14/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/14/java/kudu-spark/build.gradle@18
PS14, Line 18: apply plugin: "scala"
> Why is this plugin needed?
it's not, removed
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 15
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 06:56:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 8:
> Patch Set 8:
>
> (1 comment)
Thanks for bringing this up Alexey! I actually had done some analysis, but I only shared it with Abhishek offline. Here's the link:
https://docs.google.com/document/d/1t2DaN2kwRVZZ4IW3bDGw1O8tItkkdt1ShE0IHPm9NEQ/edit?usp=sharing
However I noticed, that the archive names are not matching either, I will work on the fix for that, I think that should be included in this commit as well, so please don't merge this until that's done.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Apr 2025 08:46:27 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#18).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the implementation and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the compileUnshaded configuration to be extending the
compileOnly configuration. This was necessary to correct the scope of
these dependencies. This change also made it necessary to add the
compileUnshaded dependencies explicitly to the test compile path as
well[0].
[0] https://blog.gradle.org/introducing-compile-only-dependencies
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
13 files changed, 85 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/18
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 18:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-backup/build.gradle
File java/kudu-backup/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-backup/build.gradle@38
PS18, Line 38: api libs.yetusAnnotations
BTW, in kudu-spark-tools and kudu-spark this is still listed as implementation type dependency. What makes kudu-backup special in that regard? Consider adding a comment here to explain.
kudu-spark/build.gradle: implementation libs.yetusAnnotations
kudu-spark-tools/build.gradle: implementation libs.yetusAnnotations
http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-hive/build.gradle@27
PS18, Line 27: api libs.hadoopCommon
Just to double-check: do we indeed need to declare this transitive dependency as 'api' here? Consider adding a comment to explain why 'api', not 'implementation' is the correct type of dependency here.
BTW, with the recent fixes on publishing and shading in PS18, do we even need to manually add this transitive dependency manually? Could Gradle7 decide what's needed or not on itself here or we still need to add this?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 May 2025 03:57:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 19:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-backup/build.gradle
File java/kudu-backup/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-backup/build.gradle@38
PS18, Line 38: implementation libs.proto
> BTW, in kudu-spark-tools and kudu-spark this is still listed as implementat
I changed this back to implementation, no reason for this to be api
http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-hive/build.gradle
File java/kudu-hive/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/18/java/kudu-hive/build.gradle@27
PS18, Line 27: testCompileOnly libs.
> Just to double-check: do we indeed need to declare this transitive dependen
good catch, indeed this is no longer required
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 19
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 May 2025 13:53:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#23).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the implementation and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the compileUnshaded configuration to be extending the
compileOnly configuration. This was necessary to correct the scope of
these dependencies. This change also made it necessary to add the
compileUnshaded dependencies explicitly to the test compile path as
well[0].
[0] https://blog.gradle.org/introducing-compile-only-dependencies
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-test-utils/build.gradle
9 files changed, 112 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/23
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 23
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 17: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1360/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 May 2025 08:29:20 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 17:
> Patch Set 17:
>
> (1 comment)
The main reason why many of the implementation scopes were changed is that when declaring them as 'api' these dependencies are not included in the generated pom.xml. This behaviour is a bit odd though, as from the documentation:
"Dependencies appearing in the api configurations will be transitively exposed to consumers of the library, and as such will appear on the compile classpath of consumers. Dependencies found in the implementation configuration will, on the other hand, not be exposed to consumers, and therefore not leak into the consumers' compile classpath."
Which seems to contradict the actual behavior of the configurations. So just to reiterate: when declaring for example "implementation libs.netty", then the netty dependency will be included in the pom as runtime dependency. These dependencies were not present at all before the gradle version upgrade (where the scopes compile and runtime are removed from gradle), so after discussing with Abhishek, we opted to switch to api since that resolved the pom issue. You can check the document I shared earlier about the pom differences, please note that the currently generated pom is much different than the "post-update" is in the document, that is basically after upgrade but before this patch.
Maybe this is a discrepancy between gradle and maven scoping behaviour. What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 May 2025 07:34:34 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/17/java/kudu-client/build.gradle
File java/kudu-client/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/17/java/kudu-client/build.gradle@42
PS17, Line 42: api libs.netty
Here and elsewhere with the dependency type changing to 'api' in recent patch sets: I'm not sure this should be of the 'api' type, at least for the 'libs.netty' in 'kudu-client' package. IIUC, 'api' in this case means that 'kudu-client' exposes at least one class from libs.netty either in its public method's parameters, return type, or type used in parent classes or interfaces. Basically, 'api' here means that at least one of the Netty's classes is a part of the kudu-client ABI. If that's indeed so, then which Netty's class is that? I couldn't find any by looking into the kudu-client API docs and into a few files in kudu-client, but I might be missing something. Could you clarify on this, please?
The same question stands for other dependencies that are now of the 'api' type here in kudu-client and other build.gradle files in PS17.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 May 2025 00:01:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 8:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22768/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22768/7//COMMIT_MSG@12
PS7, Line 12: shadow
> shadow
Done
http://gerrit.cloudera.org:8080/#/c/22768/7/java/gradle/publishing.gradle
File java/gradle/publishing.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/7/java/gradle/publishing.gradle@82
PS7, Line 82:
> nit: remove the spaces?
Done
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 17:43:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22768/17//COMMIT_MSG@17
PS17, Line 17: Additionally, the skipping of publishing wasn't working, this needed to
: be fixed for the following modules (to keep in alignment with pre-gradle
: upgrade behaviour):
: * kudu-backup-common
: * kudu-jepsen
: * kudu-proto
: * kudu-subprocess
:
: Fixed the generated jar names of the following modules:
: * kudu-backup -> kudu-backup3_2.12
: * kudu-spark -> kudu-spark3_2.12
: * kudu-spark-tools -> kudu-spark3-tools_2.12
> I wanted this changelist to fix all issues related to publishing to avoid m
Sure, if separating these fixes is a big deal and you see a risk of more delays with that, let's keep it all lumped together then.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 17:06:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 21: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1416/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 21
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jun 2025 15:48:24 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 23: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1444/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 23
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 12:17:25 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 13:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1330/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 May 2025 15:30:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#5).
Change subject: KUDU-3657 - fix publishing
......................................................................
KUDU-3657 - fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadown
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-subprocess/build.gradle
5 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/5
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 7:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1289/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 06:45:01 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#3).
Change subject: KUDU-3657 - fix publishing
......................................................................
KUDU-3657 - fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadown
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-subprocess/build.gradle
5 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/3
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: KUDU-3657 - fix publishing
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1287/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 13:57:23 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: KUDU-3657 - fix publishing
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1288/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 16:02:58 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 14: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1340/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 14
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 19:10:15 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 16:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1343/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 16
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 07:35:30 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 20:
(1 comment)
Just noticed my comment on a typo in PS18 isn't addressed yet in PS20, so just re-iterated on that. Otherwise, didn't look much at PS20 yet.
http://gerrit.cloudera.org:8080/#/c/22768/20/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/20/java/gradle/shadow.gradle@65
PS20, Line 65:
Remove the stray space?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 20
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 20:01:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 18:
Thanks for the findings on the minimize() behavior. Looks like that explains the missing classes in the jars. Cheers.
I was able to generate new set of jars and updated a copy of your POM comparison document here:
https://docs.google.com/document/d/1tDezR5Lya5ANU6Mf7nOyE-uKGvO9xkXsuFvkAt6AF_s/edit?usp=sharing
I see we have some dependencies listed earlier are no longer listed for example kudu-spark3_2.12 project has no more dependencies. Not sure if that is true, as these dependencies are not shaded.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 May 2025 00:50:48 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/18/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/18/java/gradle/shadow.gradle@65
PS18, Line 65:
nit: remove the stray space?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 17:13:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22768/17//COMMIT_MSG@17
PS17, Line 17: Additionally, the skipping of publishing wasn't working, this needed to
: be fixed for the following modules (to keep in alignment with pre-gradle
: upgrade behaviour):
: * kudu-backup-common
: * kudu-jepsen
: * kudu-proto
: * kudu-subprocess
:
: Fixed the generated jar names of the following modules:
: * kudu-backup -> kudu-backup3_2.12
: * kudu-spark -> kudu-spark3_2.12
: * kudu-spark-tools -> kudu-spark3-tools_2.12
Does it make sense to moving these items into a separate changelist, while dealing with the POM generation issues in this changelist on its own?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 May 2025 22:02:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#17).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the scope of dependencies in the kudu-client module from
implementation to api to avoid including them in the generated poms
unnecessarily.
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
12 files changed, 84 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/17
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#8).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-subprocess/build.gradle
5 files changed, 21 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/8
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 17:56:42 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 24: Code-Review+1
(1 comment)
Thank you for the updates from PS21 to PS24!
I guess this patch is closer to finish line. So far looks good to me, but I haven't verified the POM files of the published artifacts, though, but I recall that per recent discussions offline those are now in-line with what it used to be before Gradle 7 upgrade, right?
Also, it seems Abhishek had a question on PS1 -- maybe consider addressing that unless you already answered it offline.
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-client/build.gradle
File java/kudu-client/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-client/build.gradle@47
PS21, Line 47: ion project
> I opened a jira to track this: KUDU-3669
Thank you for filing this JIRA!
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 04:39:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#22).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the implementation and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the compileUnshaded configuration to be extending the
compileOnly configuration. This was necessary to correct the scope of
these dependencies. This change also made it necessary to add the
compileUnshaded dependencies explicitly to the test compile path as
well[0].
[0] https://blog.gradle.org/introducing-compile-only-dependencies
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-test-utils/build.gradle
9 files changed, 110 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/22
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 22
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 22: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1442/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 22
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jun 2025 17:03:06 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 16: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1351/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 16
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 22:05:57 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 14: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1338/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 14
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 12:56:29 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#9).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
8 files changed, 31 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/9
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 9
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 10: Code-Review+1
I was able to test the java example from the Kudu repo with older kudu-client.jar version (1.17.0) and the newer (1.18.0) and it didn't throw any issues due to newly added runtime dependencies.
But I think Alexey's concern is about obtaining these new dependencies in environments without/controlled internet access which were otherwise I believe optional in older Gradle version. I put a note in the release notes on this to set expectations but let me know what you think too.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 10
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Apr 2025 04:25:32 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 10:
> Patch Set 10:
>
> (1 comment)
If you check the install/publish directory, you'll see that the kudu-proto.jar is not present. This is because we skip the publishing of it on purpose, as it's contents are shaded into the kudu-client.jar (see note at kudu-proto/build.gradle#40).
The kudu-proto.jar will be generated when running a simple ./gradlew assemble, under '/kudu/java/kudu-proto/build/libs' you can check it's contents and the contents of the kudu-client.jar with 'jar -tf <jar_path>' which will show that the generated proto classes and the google protobuf classes are both present in the kudu-client jar, so the change of scope for this shouldn't cause any classpath issue.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 10
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Apr 2025 07:56:30 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#11).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
9 files changed, 32 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/11
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 11
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 18:
(1 comment)
> Patch Set 17:
>
> > Patch Set 16:
> >
> > As discussed offline, the jars need to be validated if they contain the needed jars. For example the kudu-client.jar is missing a few classes from netty project:
> >
> > [root@ccycloud 1.18.0-SNAPSHOT]# jar -tf kudu-client-1.17.1.jar | grep "org/apache/kudu/shaded" | awk -F "/" '{print $5, $6}' | uniq -c
> > 1
> > 1 com
> > 2042 com google
> > 1 io
> > 412 io micrometer
> > 6 com sangupta
> > 684 com google
> > 1 org
> > 422 org checkerframework
> > 98 org HdrHistogram
> > 23 org LatencyUtils
> > 3139 io netty
> > [root@ccycloud 1.18.0-SNAPSHOT]# jar -tf kudu-client-1.18.0-SNAPSHOT.jar | grep "org/apache/kudu/shaded" | awk -F "/" '{print $5, $6}' | uniq -c
> > 1
> > 1 com
> > 2776 com google
> > 1 io
> > 412 io micrometer
> > 6 com sangupta
> > 3 com google
> > 1 org
> > 18 org checkerframework
> > 62 org HdrHistogram
> > 20 org LatencyUtils
> > 1107 io netty
>
> I'm looking into this, at a first glance, the versions of netty is different between 1.17.1 and the tip of master, it is 4.1.110.Final and 4.1.115.Final respectively. I'm not sure if the difference can simply be explained by this. Will look into it further.
I've done some more investigation on this. Turns out that this is due to calling 'minimize()' in the kudu-client module's shadowJar section. This basically excludes all not used classes from making it into the generated jar.
see: https://gradleup.com/shadow/configuration/minimizing/
http://gerrit.cloudera.org:8080/#/c/22768/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22768/17//COMMIT_MSG@17
PS17, Line 17: Additionally, the skipping of publishing wasn't working, this needed to
: be fixed for the following modules (to keep in alignment with pre-gradle
: upgrade behaviour):
: * kudu-backup-common
: * kudu-jepsen
: * kudu-proto
: * kudu-subprocess
:
: Fixed the generated jar names of the following modules:
: * kudu-backup -> kudu-backup3_2.12
: * kudu-spark -> kudu-spark3_2.12
: * kudu-spark-tools -> kudu-spark3-tools_2.12
> Does it make sense to moving these items into a separate changelist, while
I wanted this changelist to fix all issues related to publishing to avoid more review cycles. I can separate them, but I feel like I wasted a lot of time already and don't want to hold up the 1.18 release any longer than necessary.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 18
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 May 2025 11:28:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 15:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1342/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 15
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 06:56:41 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 16:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1344/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 16
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 07:36:40 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 19:
(3 comments)
Looks better compared with PS18, just a few nits and questions left.
http://gerrit.cloudera.org:8080/#/c/22768/18/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/18/java/gradle/shadow.gradle@65
PS18, Line 65:
> nit: remove the stray space?
Did you miss addressing this strayed space in PS19?
http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup-tools/build.gradle
File java/kudu-backup-tools/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup-tools/build.gradle@49
PS19, Line 49: testCompileOnly project(path: ":kudu-backup-common")
Is this a duplicate for the directive at line 38 above?
http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup/build.gradle
File java/kudu-backup/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/19/java/kudu-backup/build.gradle@48
PS19, Line 48: testCompileOnly
Wouldn't it be enough to have testImplementation dependency from 'kudu-spark' for 'shadow' configuration, instead of this testCompileOnly for 'shadow' configuration and testImplementation below at line 52 for 'test' configuration as well?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 19
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 May 2025 18:58:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 7: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/1289/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 07:25:37 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 19:
> Patch Set 19: Verified-1
>
> Build Failed
>
> http://jenkins.kudu.apache.org/job/pre_commit/1389/ : FAILURE
Please ignore this patchset, the test classpath is not yet correct.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 19
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 May 2025 15:19:45 +0000
Gerrit-HasComments: No
[kudu-CR] [WIP] KUDU-3657 - fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [WIP] KUDU-3657 - fix publishing
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1286/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 13:28:53 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 23:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1444/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 23
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 11:20:58 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 24:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-client/build.gradle
File java/kudu-client/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-client/build.gradle@47
PS21, Line 47: ion project
> It's not related to this changelist, but overall migration off from jsr305
I opened a jira to track this: KUDU-3669
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 13:24:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 24: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1454/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 14:11:56 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 24: Code-Review+2
> Tested the newly published jars and found no issues:
> - Impala can create a table and read/write to it
> - Same with Spark3
> - Tested backing up of Kudu tables and restoring with the new jars
> - Tested table creation/renaming in Kudu are reflected in HMS
> database
> Let's wait for a +2 from Alexey too before merging.
Thanks a lot for verifying Java artifacts, Abhishek!
PS24 of this changelist LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jun 2025 01:12:25 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22768/5/java/kudu-jepsen/build.gradle
File java/kudu-jepsen/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/5/java/kudu-jepsen/build.gradle@73
PS5, Line 73: publishMavenPublicationToMa
> Here and everywhere else:
no, removed
http://gerrit.cloudera.org:8080/#/c/22768/5/java/kudu-jepsen/build.gradle@74
PS5, Line 74: publishMavenPublicationToMavenRepository.enabled = false
: publishAllPublicationsToMavenRepository.enabled = false
:
> As per commit message, these tasks need to be disabled due to Gradle7 upgra
Yes, in a way. The publishing tasks are different, as the publishing plugin was switched to 'maven-publish', since the old one is no longer supported/working on gradle7. But the module itself wasn't published even before the gradle upgrade, you can find the reasoning in the comments before these blocks (e.g. in this file's #71 line or kudu-proto/build.gradle#40)
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 06:45:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: KUDU-3657 - fix publishing
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22768/5/java/kudu-jepsen/build.gradle
File java/kudu-jepsen/build.gradle:
http://gerrit.cloudera.org:8080/#/c/22768/5/java/kudu-jepsen/build.gradle@73
PS5, Line 73: publishToMavenLocal.enabled
Here and everywhere else:
Do we still need this?
http://gerrit.cloudera.org:8080/#/c/22768/5/java/kudu-jepsen/build.gradle@74
PS5, Line 74: publishMavenPublicationToMavenLocal.enabled = false
: publishMavenPublicationToMavenRepository.enabled = false
: publishAllPublicationsToMavenRepository.enabled = false
As per commit message, these tasks need to be disabled due to Gradle7 upgrade or is there any other specific reason?
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 23:49:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3657 - fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#4).
Change subject: KUDU-3657 - fix publishing
......................................................................
KUDU-3657 - fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadown
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-subprocess/build.gradle
5 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/4
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 8:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1290/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 17:43:58 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 13:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1330/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 May 2025 19:25:41 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 13:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1331/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 May 2025 19:30:31 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 12: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1328/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 12
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 May 2025 12:58:48 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 13: Verified+1
unrelated test failures:
debug: partition_pruner-test.0,
tsan:ksck_remote-test.0, org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 13
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 11:22:43 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 23:
> Patch Set 23:
>
> Build Started http://jenkins.kudu.apache.org/job/pre_commit/1444/
I updated the document with the new pom contents:
https://docs.google.com/document/d/1t2DaN2kwRVZZ4IW3bDGw1O8tItkkdt1ShE0IHPm9NEQ/edit?tab=t.0
It's almost completely identical to the pre-upgrade poms, with the caveat that provided dependencies now are represented as compile scoped.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 23
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Jun 2025 12:24:17 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 17:
> Patch Set 16:
>
> As discussed offline, the jars need to be validated if they contain the needed jars. For example the kudu-client.jar is missing a few classes from netty project:
>
> [root@ccycloud 1.18.0-SNAPSHOT]# jar -tf kudu-client-1.17.1.jar | grep "org/apache/kudu/shaded" | awk -F "/" '{print $5, $6}' | uniq -c
> 1
> 1 com
> 2042 com google
> 1 io
> 412 io micrometer
> 6 com sangupta
> 684 com google
> 1 org
> 422 org checkerframework
> 98 org HdrHistogram
> 23 org LatencyUtils
> 3139 io netty
> [root@ccycloud 1.18.0-SNAPSHOT]# jar -tf kudu-client-1.18.0-SNAPSHOT.jar | grep "org/apache/kudu/shaded" | awk -F "/" '{print $5, $6}' | uniq -c
> 1
> 1 com
> 2776 com google
> 1 io
> 412 io micrometer
> 6 com sangupta
> 3 com google
> 1 org
> 18 org checkerframework
> 62 org HdrHistogram
> 20 org LatencyUtils
> 1107 io netty
I'm looking into this, at a first glance, the versions of netty is different between 1.17.1 and the tip of master, it is 4.1.110.Final and 4.1.115.Final respectively. I'm not sure if the difference can simply be explained by this. Will look into it further.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 17
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 May 2025 17:09:27 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 16:
As discussed offline, the jars need to be validated if they contain the needed jars. For example the kudu-client.jar is missing a few classes from netty project:
[root@ccycloud 1.18.0-SNAPSHOT]# jar -tf kudu-client-1.17.1.jar | grep "org/apache/kudu/shaded" | awk -F "/" '{print $5, $6}' | uniq -c
1
1 com
2042 com google
1 io
412 io micrometer
6 com sangupta
684 com google
1 org
422 org checkerframework
98 org HdrHistogram
23 org LatencyUtils
3139 io netty
[root@ccycloud 1.18.0-SNAPSHOT]# jar -tf kudu-client-1.18.0-SNAPSHOT.jar | grep "org/apache/kudu/shaded" | awk -F "/" '{print $5, $6}' | uniq -c
1
1 com
2776 com google
1 io
412 io micrometer
6 com sangupta
3 com google
1 org
18 org checkerframework
62 org HdrHistogram
20 org LatencyUtils
1107 io netty
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 16
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 22:15:12 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#16).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the api and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the scope of dependencies in the kudu-client module from
implementation to api to avoid including them in the generated poms
unnecessarily.
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
12 files changed, 84 insertions(+), 60 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/16
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 16
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 16:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1343/
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 16
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 07:10:41 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22768
to look at the new patch set (#19).
Change subject: [java] KUDU-3657: fix publishing
......................................................................
[java] KUDU-3657: fix publishing
The changes introduced in KUDU-3610 have fixed the POM generation for
the kudu-hive java module, however the publishing for other modules were
broken as a side-effect. This patch aims to fix these issues.
The change in publishing.gradle file checks if the implementation and shadow
configurations are present to calculate the correct pom to be generated.
If they are not present for the given module, they are simply filled out
as empty arrays.
Additionally, the skipping of publishing wasn't working, this needed to
be fixed for the following modules (to keep in alignment with pre-gradle
upgrade behaviour):
* kudu-backup-common
* kudu-jepsen
* kudu-proto
* kudu-subprocess
Fixed the generated jar names of the following modules:
* kudu-backup -> kudu-backup3_2.12
* kudu-spark -> kudu-spark3_2.12
* kudu-spark-tools -> kudu-spark3-tools_2.12
Changed the compileUnshaded configuration to be extending the
compileOnly configuration. This was necessary to correct the scope of
these dependencies. This change also made it necessary to add the
compileUnshaded dependencies explicitly to the test compile path as
well[0].
[0] https://blog.gradle.org/introducing-compile-only-dependencies
Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup/build.gradle
M java/kudu-client/build.gradle
M java/kudu-hive/build.gradle
M java/kudu-jepsen/build.gradle
M java/kudu-proto/build.gradle
M java/kudu-spark-tools/build.gradle
M java/kudu-spark/build.gradle
M java/kudu-subprocess/build.gradle
M java/kudu-test-utils/build.gradle
13 files changed, 202 insertions(+), 170 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22768/19
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 19
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [java] KUDU-3657: fix publishing
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing
......................................................................
Patch Set 24:
> Patch Set 24: Code-Review+1
>
> (1 comment)
>
> Thank you for the updates from PS21 to PS24!
>
> I guess this patch is closer to finish line. So far looks good to me, but I haven't verified the POM files of the published artifacts, though, but I recall that per recent discussions offline those are now in-line with what it used to be before Gradle 7 upgrade, right?
>
> Also, it seems Abhishek had a question on PS1 -- maybe consider addressing that unless you already answered it offline.
Yeah, the listed dependencies in the poms should be practically identical to previously releases (with the difference of provided->compile scope). I believe Abhishek's question was similar, so I think it's answered, but if there are any other questions that I missed, please let me know.
--
To view, visit http://gerrit.cloudera.org:8080/22768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0
Gerrit-Change-Number: 22768
Gerrit-PatchSet: 24
Gerrit-Owner: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 14:46:24 +0000
Gerrit-HasComments: No