You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/22 09:19:31 UTC
[GitHub] [airflow] Inetov opened a new pull request, #25865: fix: rename directory for Windows users
Inetov opened a new pull request, #25865:
URL: https://github.com/apache/airflow/pull/25865
it's just renaming the log directory for Windows users can clone your repository.
Windows not allow ":" in file/directory name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25865: fix: rename directory for Windows users
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25865:
URL: https://github.com/apache/airflow/pull/25865#issuecomment-1229036710
Closing for now then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Inetov commented on pull request #25865: fix: rename directory for Windows users
Posted by GitBox <gi...@apache.org>.
Inetov commented on PR #25865:
URL: https://github.com/apache/airflow/pull/25865#issuecomment-1222419975
> I don't think that is possible to change directory/filename seems like it test default log format. However tests might create this files in temp directory.
>
> Or windows users might run `git config core.protectNTFS false` before clone repo or better clone inside WSL 2
OK, thanks! this is harder than it seemed, I don't have time to finish it yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #25865: fix: rename directory for Windows users
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #25865:
URL: https://github.com/apache/airflow/pull/25865#issuecomment-1222403622
It could possible to override this in tests with `conf_var` or something. But either way the “fix” would be more involved than just renaming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Inetov commented on pull request #25865: fix: rename directory for Windows users
Posted by GitBox <gi...@apache.org>.
Inetov commented on PR #25865:
URL: https://github.com/apache/airflow/pull/25865#issuecomment-1222275786
> You will have to also fix some tests most likely
I did not find in the code where this name / path to the file would be used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #25865: fix: rename directory for Windows users
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #25865:
URL: https://github.com/apache/airflow/pull/25865#issuecomment-1222338852
> I did not find in the code where this name / path to the file would be used
https://github.com/apache/airflow/blob/main/tests/www/views/test_views_log.py
I don't think that is possible to change directory/filename seems like it test default log format.
However tests might create this files in temp directory.
Or windows users might run `git config core.protectNTFS false` before clone repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25865: fix: rename directory for Windows users
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25865:
URL: https://github.com/apache/airflow/pull/25865#issuecomment-1222084405
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #25865: fix: rename directory for Windows users
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #25865: fix: rename directory for Windows users
URL: https://github.com/apache/airflow/pull/25865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25865: fix: rename directory for Windows users
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25865:
URL: https://github.com/apache/airflow/pull/25865#issuecomment-1222188025
You will have to also fix some tests most likely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org