You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2009/01/22 03:00:13 UTC

DO NOT REPLY [Bug 46580] New: NotImplementedFunction should throw an exception instead of silent internal errors

https://issues.apache.org/bugzilla/show_bug.cgi?id=46580

           Summary: NotImplementedFunction should throw an exception instead
                    of silent internal errors
           Product: POI
           Version: 3.0
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HSSF
        AssignedTo: dev@poi.apache.org
        ReportedBy: josh@gildedtree.com


This change was motivated by these threads:
http://mail-archives.apache.org/mod_mbox/poi-user/200901.mbox/%3Ca644352c0901131503q44ce53a0ld9e225bbe0419642@mail.gmail.com%3E

http://mail-archives.apache.org/mod_mbox/poi-user/200901.mbox/%3C4551EAB41622EC4AA6CFAAB005485C01D533FD@SFPWMF107.polk.com%3E

When the evaluator comes across an unimplemented function, an internal error
code was returned.  This value is not suitable for writing into a FormulaRecord
or BoolErrRecord, because it causes errors when opening the file in Excel.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

DO NOT REPLY [Bug 46580] NotImplementedFunction should throw an exception instead of silent internal errors

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46580


Josh Micich <jo...@gildedtree.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Josh Micich <jo...@gildedtree.com>  2009-01-21 18:00:34 PST ---
The fix is to remove ErrorEval.FUNCTION_NOT_IMPLEMENTED change all methods that
returned that value to throw NotImplementedException instead.

Applied in svn r736505 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=736505 )

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org