You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/24 07:47:18 UTC

[GitHub] [airflow] jedcunningham commented on a change in pull request #20487: Remove unneeded FAB REST API endpoints

jedcunningham commented on a change in pull request #20487:
URL: https://github.com/apache/airflow/pull/20487#discussion_r774915194



##########
File path: airflow/www/extensions/init_appbuilder.py
##########
@@ -211,7 +211,6 @@ def init_app(self, app, session):
         self.sm = self.security_manager_class(self)
         self.bm = BabelManager(self)
         self.openapi_manager = OpenApiManager(self)
-        self.menuapi_manager = MenuApiManager(self)

Review comment:
       I'm good with removing `OpenApi` too, even though that didn't actually add any endpoints in practice 🤷‍♂️.
   
   We do want to remove `MenuApi`, which exposes `/api/v1/menu`. It's a FAB default we don't want, particularly now that we are removing the default FAB REST API auth endpoints too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org