You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2020/06/25 16:34:00 UTC

[jira] [Comment Edited] (CASSANDRA-13994) Remove COMPACT STORAGE internals before 4.0 release

    [ https://issues.apache.org/jira/browse/CASSANDRA-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145076#comment-17145076 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-13994 at 6/25/20, 4:33 PM:
---------------------------------------------------------------------------

Thanks [~slebresne] for spending the time on this. Appreciate it!
I also did a quick CCM test upgrading locally while still having the indexes and I didn't see any issues. 

If the community still wants the dead code removed, I can rebase and go through the points of your initial review next week. (and returning the KEYS index back of course)




was (Author: e.dimitrova):
Thanks [~slebresne] for spending the time on this. Appreciate it!
I also did a quick CCM test upgrading locally while still having the indexes and I didn't see any issues. 

If the community still wants the dead code removed, I can rebase and go through the points of your initial review next week. (and returning the KEY index back of course)



> Remove COMPACT STORAGE internals before 4.0 release
> ---------------------------------------------------
>
>                 Key: CASSANDRA-13994
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13994
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Local Write-Read Paths
>            Reporter: Alex Petrov
>            Assignee: Ekaterina Dimitrova
>            Priority: Low
>             Fix For: 4.0, 4.0-alpha
>
>
> 4.0 comes without thrift (after [CASSANDRA-11115]) and COMPACT STORAGE (after [CASSANDRA-10857]), and since Compact Storage flags are now disabled, all of the related functionality is useless.
> There are still some things to consider:
> 1. One of the system tables (built indexes) was compact. For now, we just added {{value}} column to it to make sure it's backwards-compatible, but we might want to make sure it's just a "normal" table and doesn't have redundant columns.
> 2. Compact Tables were building indexes in {{KEYS}} mode. Removing it is trivial, but this would mean that all built indexes will be defunct. We could log a warning for now and ask users to migrate off those for now and completely remove it from future releases. It's just a couple of classes though.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org