You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sandesha-dev@ws.apache.org by ga...@apache.org on 2007/06/11 13:22:23 UTC

svn commit: r546095 - /webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java

Author: gatfora
Date: Mon Jun 11 04:22:22 2007
New Revision: 546095

URL: http://svn.apache.org/viewvc?view=rev&rev=546095
Log:
Avoid NPE when unblocking the CreateSequence message transport

Modified:
    webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java

Modified: webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java
URL: http://svn.apache.org/viewvc/webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java?view=diff&rev=546095&r1=546094&r2=546095
==============================================================================
--- webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java (original)
+++ webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java Mon Jun 11 04:22:22 2007
@@ -397,7 +397,7 @@
 				if (inMsg != null)
 					t = (RequestResponseTransport) inMsg.getProperty(RequestResponseTransport.TRANSPORT_CONTROL);
 	
-				if((t != null || !t.getStatus().equals(RequestResponseTransportStatus.WAITING))) {
+				if((t != null && !RequestResponseTransportStatus.WAITING.equals(t.getStatus()))) {
 					if(log.isWarnEnabled()) {
 						String message = SandeshaMessageHelper.getMessage(SandeshaMessageKeys.freeingTransport);
 						log.warn(message);



---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


Re: svn commit: r546095 - /webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java

Posted by Chamikara Jayalath <ch...@gmail.com>.
Hi Andrew,

It is great if you can add this kind of bug fixes to the 1.2 branch as well.
I'm thinking of going for a 1.2.1 (a solid one :-) ).

Chamikara


On 6/11/07, gatfora@apache.org <ga...@apache.org> wrote:
>
> Author: gatfora
> Date: Mon Jun 11 04:22:22 2007
> New Revision: 546095
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=546095
> Log:
> Avoid NPE when unblocking the CreateSequence message transport
>
> Modified:
>
>     webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java
>
> Modified:
> webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java
> URL:
> http://svn.apache.org/viewvc/webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java?view=diff&rev=546095&r1=546094&r2=546095
>
> ==============================================================================
> ---
> webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java
> (original)
> +++
> webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/Sender.java
> Mon Jun 11 04:22:22 2007
> @@ -397,7 +397,7 @@
>                                 if (inMsg != null)
>                                         t = (RequestResponseTransport)
> inMsg.getProperty(RequestResponseTransport.TRANSPORT_CONTROL);
>
> -                               if((t != null || !t.getStatus().equals(
> RequestResponseTransportStatus.WAITING))) {
> +                               if((t != null &&
> !RequestResponseTransportStatus.WAITING.equals(t.getStatus()))) {
>                                         if(log.isWarnEnabled()) {
>                                                 String message =
> SandeshaMessageHelper.getMessage(SandeshaMessageKeys.freeingTransport);
>                                                 log.warn(message);
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: sandesha-dev-help@ws.apache.org
>
>


-- 
Chamikara Jayalath
WSO2 Inc.
http://wso2.com/
http://wso2.org/ - For your Oxygen needs