You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/16 20:30:51 UTC

[GitHub] [beam] KevinGG edited a comment on issue #11138: [BEAM-8335] Refactor IPythonLogHandler

KevinGG edited a comment on issue #11138: [BEAM-8335] Refactor IPythonLogHandler
URL: https://github.com/apache/beam/pull/11138#issuecomment-599743020
 
 
   Formatted.
   Lint has passed locally.
   
   The change is mainly moving `register_log_handler` from `utils.interactive_utils` to `runners.interactive.utils`.
   
   The logic change is to use `record.msg % record.args` as the message instead of just `record.msg`.
   
   Together with some minor fixes.
   
   R: @pabloem 
   R: @davidyan74 
   R: @rohdesamuel 
   
   PTAL, thx!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services