[jira] [Comment Edited] (MESOS-3037) Add a QUIESCE call to the scheduler

["Guangya Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698894#comment-14698894 ] 

Guangya Liu edited comment on MESOS-3037 at 9/18/15 11:38 PM:
--------------------------------------------------------------

There will be some function conflict with signals.hpp if use SUPPRESS offer, I was planning to use QUIESCE call
{code}
../../3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp:28:3: error: expected unqualified-id before 'if'
   if (os::signals::internal::Suppressor suppressor ## signal = \
   ^
../include/mesos/scheduler/scheduler.pb.h:2238:51: note: in expansion of macro 'suppress'
   inline const ::mesos::scheduler::Call_Suppress& suppress() const;
                                                   ^
In file included from ../../include/mesos/scheduler/scheduler.hpp:23:0,
                 from ../../include/mesos/type_utils.hpp:30,
                 from ../../include/mesos/resources.hpp:29,
                 from ../../src/slave/containerizer/isolators/filesystem/linux.hpp:23,
                 from ../../src/slave/containerizer/isolators/filesystem/linux.cpp:39:
../include/mesos/scheduler/scheduler.pb.h:2238:49: error: expected ';' at end of member declaration
   inline const ::mesos::scheduler::Call_Suppress& suppress() const;
{/code}
                                                 ^


was (Author: gyliu):
There will be some function conflict with signals.hpp if use SUPPRESS offer, I was planning to use QUIESCE call

../../3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp:28:3: error: expected unqualified-id before 'if'
   if (os::signals::internal::Suppressor suppressor ## signal = \
   ^
../include/mesos/scheduler/scheduler.pb.h:2238:51: note: in expansion of macro 'suppress'
   inline const ::mesos::scheduler::Call_Suppress& suppress() const;
                                                   ^
In file included from ../../include/mesos/scheduler/scheduler.hpp:23:0,
                 from ../../include/mesos/type_utils.hpp:30,
                 from ../../include/mesos/resources.hpp:29,
                 from ../../src/slave/containerizer/isolators/filesystem/linux.hpp:23,
                 from ../../src/slave/containerizer/isolators/filesystem/linux.cpp:39:
../include/mesos/scheduler/scheduler.pb.h:2238:49: error: expected ';' at end of member declaration
   inline const ::mesos::scheduler::Call_Suppress& suppress() const;
                                                 ^

> Add a QUIESCE call to the scheduler
> -----------------------------------
>
>                 Key: MESOS-3037
>                 URL: https://issues.apache.org/jira/browse/MESOS-3037
>             Project: Mesos
>          Issue Type: Improvement
>    Affects Versions: 0.25.0
>            Reporter: Vinod Kone
>            Assignee: Guangya Liu
>              Labels: September23th
>             Fix For: 0.25.0
>
>
> SUPPRESS call is the complement to the current REVIVE call i.e., it will inform Mesos to stop sending offers to the framework. 
> For the scheduler driver to send only Call messages (MESOS-2913), DeactivateFrameworkMessage needs to be converted to Call(s). We can implement this by having the driver send a SUPPRESS call followed by a DECLINE call for outstanding offers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)