Re: [I] test(desktop): the Storybook smoke renders one of 22 palette × colour-scheme combinations [maka]

["liuxiaocs7 (via GitHub)" <gi...@apache.org>]

liuxiaocs7 commented on issue #3942:
URL: https://github.com/apache/maka/issues/3942#issuecomment-5521861585

   Cross-reference (not a claim — this is assigned): #3944 just landed the failure/edge-state Storybook stories for the high-traffic surfaces — nine PRs merged across chat rendering/streaming, tool results, error/toast, file diff / change panel, terminal, browser, agent graph, daily review, and model picker. They render **real production components** in states this smoke never saw before: error/failed banners, empty states, provider-retry, very-long-text, very-many-rows, etc.
   
   Two places they intersect with this issue:
   
   - **The `colorScheme` parameterisation.** Those new stories are only exercised at `default × light` today. The moment `storyUrl` runs dark as well, every new failure-state story comes along as a dark-mode target for free — I captured dark (and narrow) screenshots of each by hand for review, which is exactly the manual human oracle this issue wants to turn into a CI one.
   - **The per-text-node contrast assertion.** The new failure states introduce status-coloured text — error banners, the destructive-confirm action, the provider-retry indicator — that a contrast check should cover. #3446 F6's `--color-text-disabled` failure lives on transcript body copy, which #3944's chat stories now render across failure classes, so the assertion would have those surfaces to run against.
   
   So the two are complementary axes: #3944 widened the *states*; this issue widens the *palette × colour-scheme* dimension and adds the assertion. Flagging so the surfaces line up — happy to share the new story ids if that helps when you parameterise the smoke.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org