You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/03/05 13:27:23 UTC

[GitHub] [maven-shared-io] elharo opened a new pull request, #20: update to Java 8 minimum

elharo opened a new pull request, #20:
URL: https://github.com/apache/maven-shared-io/pull/20

   spotless also did some trivial formatting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-io] elharo commented on pull request #20: [MSHARED-1195] update to Java 8 minimum

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #20:
URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455099647

   added JIRA issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #20:
URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455092495

   There appears to be a pre-existing formatting issue:
   
   ```
   [INFO] Index file does not exist. Fallback to an empty index
   
   WARNING: An illegal reflective access operation has occurred
   
   WARNING: Illegal reflective access by com.palantir.javaformat.java.JavacTokens$CommentSavingTokenizer (file:/home/jenkins/jenkins-home/workspace/n_maven-box_maven-shared-io_jdk8@2/.repository/com/palantir/javaformat/palantir-java-format/2.28.0/palantir-java-format-2.28.0.jar) to field com.sun.tools.javac.parser.JavaTokenizer.reader
   
   WARNING: Please consider reporting this to the maintainers of com.palantir.javaformat.java.JavacTokens$CommentSavingTokenizer
   
   WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
   
   WARNING: All illegal access operations will be denied in a future release
   
   [ERROR] Step 'palantir-java-format' found problem in 'src/test/java/org/apache/maven/shared/io/location/FileLocationTest.java':
   
   error: Imports not contiguous (perhaps a comment separates them?)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-io] elharo merged pull request #20: [MSHARED-1195] update to Java 8 minimum

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #20:
URL: https://github.com/apache/maven-shared-io/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-io] slachiewicz commented on pull request #20: [MSHARED-1195] update to Java 8 minimum

Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #20:
URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455106550

   Jira should be in commit message 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #20:
URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455094613

   I assumed the parent was previously blocked by JDK 7, but maybe removing that will bypass the broken spotless checks. Frankly, spotless is too buggy and I wish we weren't using it, but let me try. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-io] elharo commented on pull request #20: update to Java 8 minimum

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #20:
URL: https://github.com/apache/maven-shared-io/pull/20#issuecomment-1455096798

   Reverting the parent does seem to sidestep the spotless bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org