You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/20 00:41:40 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5555: boards: Remove the unnecessary customize Make.defs
xiaoxiang781216 opened a new pull request #5555:
URL: https://github.com/apache/incubator-nuttx/pull/5555
## Summary
since the general Make.defs in scripts folder is enough
## Impact
No
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5555: boards: Remove the unnecessary customize Make.defs
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5555:
URL: https://github.com/apache/incubator-nuttx/pull/5555#discussion_r810632979
##########
File path: boards/arm/stm32/stm32f4discovery/scripts/Make.defs
##########
@@ -35,7 +35,11 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCFLAGS = -fno-builtin
-ARCHCXXFLAGS = -fno-builtin -fno-exceptions -fcheck-new
+ifeq ($(CONFIG_CXX_EXCEPTION),y)
+ ARCHCXXFLAGS = -fno-builtin
+else
+ ARCHCXXFLAGS = -fno-builtin -fno-exceptions -fcheck-new
Review comment:
Why we do not have `-fno-rtti` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5555: boards: Remove the unnecessary customize Make.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5555:
URL: https://github.com/apache/incubator-nuttx/pull/5555#discussion_r811121907
##########
File path: boards/arm/imxrt/imxrt1060-evk/configs/libcxxtest/Make.defs
##########
@@ -1,80 +0,0 @@
-############################################################################
-# boards/arm/imxrt/imxrt1060-evk/configs/libcxxtest/Make.defs
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership. The
-# ASF licenses this file to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance with the
-# License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
-#
-############################################################################
-
-include $(TOPDIR)/.config
-include $(TOPDIR)/tools/Config.mk
-include $(TOPDIR)/arch/arm/src/armv7-m/Toolchain.defs
-
-ifeq ($(CONFIG_ARMV7M_DTCM),y)
- LDSCRIPT = flash-dtcm.ld
-else
- LDSCRIPT = flash-ocram.ld
Review comment:
https://github.com/apache/incubator-nuttx/blob/master/boards/arm/imxrt/imxrt1060-evk/scripts/Make.defs#L25-L29
BTW, flash-dtcm.ld doesn't exist, this file is already broken when CONFIG_ARMV7M_DTCM equals y.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5555: boards: Remove the unnecessary customize Make.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5555:
URL: https://github.com/apache/incubator-nuttx/pull/5555#discussion_r810636324
##########
File path: boards/arm/stm32/stm32f4discovery/scripts/Make.defs
##########
@@ -35,7 +35,11 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
endif
ARCHCFLAGS = -fno-builtin
-ARCHCXXFLAGS = -fno-builtin -fno-exceptions -fcheck-new
+ifeq ($(CONFIG_CXX_EXCEPTION),y)
+ ARCHCXXFLAGS = -fno-builtin
+else
+ ARCHCXXFLAGS = -fno-builtin -fno-exceptions -fcheck-new
Review comment:
Add at line 52:
https://github.com/apache/incubator-nuttx/pull/5555/files#diff-0a874401241f632c07d97d166345317a75e439db54eb33b3082394ba2a6749bbL48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5555: boards: Remove the unnecessary customize Make.defs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5555:
URL: https://github.com/apache/incubator-nuttx/pull/5555#discussion_r811121907
##########
File path: boards/arm/imxrt/imxrt1060-evk/configs/libcxxtest/Make.defs
##########
@@ -1,80 +0,0 @@
-############################################################################
-# boards/arm/imxrt/imxrt1060-evk/configs/libcxxtest/Make.defs
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership. The
-# ASF licenses this file to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance with the
-# License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
-#
-############################################################################
-
-include $(TOPDIR)/.config
-include $(TOPDIR)/tools/Config.mk
-include $(TOPDIR)/arch/arm/src/armv7-m/Toolchain.defs
-
-ifeq ($(CONFIG_ARMV7M_DTCM),y)
- LDSCRIPT = flash-dtcm.ld
-else
- LDSCRIPT = flash-ocram.ld
Review comment:
https://github.com/apache/incubator-nuttx/blob/master/boards/arm/imxrt/imxrt1060-evk/scripts/Make.defs#L25-L29
BTW, flash-dtcm.ld doesn't exist in the current code base, this file is already broken when CONFIG_ARMV7M_DTCM equals y.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5555: boards: Remove the unnecessary customize Make.defs
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #5555:
URL: https://github.com/apache/incubator-nuttx/pull/5555#discussion_r811119648
##########
File path: boards/arm/imxrt/imxrt1060-evk/configs/libcxxtest/Make.defs
##########
@@ -1,80 +0,0 @@
-############################################################################
-# boards/arm/imxrt/imxrt1060-evk/configs/libcxxtest/Make.defs
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership. The
-# ASF licenses this file to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance with the
-# License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
-#
-############################################################################
-
-include $(TOPDIR)/.config
-include $(TOPDIR)/tools/Config.mk
-include $(TOPDIR)/arch/arm/src/armv7-m/Toolchain.defs
-
-ifeq ($(CONFIG_ARMV7M_DTCM),y)
- LDSCRIPT = flash-dtcm.ld
-else
- LDSCRIPT = flash-ocram.ld
Review comment:
@xiaoxiang781216 Where is this functionality now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5555: boards: Remove the unnecessary customize Make.defs
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5555:
URL: https://github.com/apache/incubator-nuttx/pull/5555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org