You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "E. Sammer (JIRA)" <ji...@apache.org> on 2011/05/27 00:48:47 UTC
[jira] [Created] (MRUNIT-14) Support JobConfigurable and Closable
interfaces
Support JobConfigurable and Closable interfaces
-----------------------------------------------
Key: MRUNIT-14
URL: https://issues.apache.org/jira/browse/MRUNIT-14
Project: MRUnit
Issue Type: Improvement
Affects Versions: 0.5.0
Reporter: E. Sammer
MRUnit should support the invocation of a mapper or reducer's configure() and close() methods as dictated by JobConfigurable and Closable respectively.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MRUNIT-14) Support JobConfigurable and Closable
interfaces
Posted by "Brock Noland (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland reassigned MRUNIT-14:
----------------------------------
Assignee: Brock Noland
> Support JobConfigurable and Closable interfaces
> -----------------------------------------------
>
> Key: MRUNIT-14
> URL: https://issues.apache.org/jira/browse/MRUNIT-14
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.5.0
> Reporter: E. Sammer
> Assignee: Brock Noland
> Fix For: 0.8.0
>
>
> MRUnit should support the invocation of a mapper or reducer's configure() and close() methods as dictated by JobConfigurable and Closable respectively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MRUNIT-14) Support JobConfigurable and Closable
interfaces
Posted by "Brock Noland (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland resolved MRUNIT-14.
--------------------------------
Resolution: Fixed
Committed in 1207646.
> Support JobConfigurable and Closable interfaces
> -----------------------------------------------
>
> Key: MRUNIT-14
> URL: https://issues.apache.org/jira/browse/MRUNIT-14
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.5.0
> Reporter: E. Sammer
> Assignee: Brock Noland
> Fix For: 0.8.0
>
>
> MRUnit should support the invocation of a mapper or reducer's configure() and close() methods as dictated by JobConfigurable and Closable respectively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-14) Support JobConfigurable and Closable
interfaces
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216640#comment-13216640 ]
Brock Noland commented on MRUNIT-14:
------------------------------------
I think there are two issues above:
1) Multiple input key value pairs
2) Calling configure with an empty configuration object.
I think the testing of multiple input key, value pairs should be handled in a fashion other than a static mapper. That is I would like to see MRUnit have the ability to process multiple input key value pairs in a single test with no statics or instance variable hacks. I created MRUNIT-64 to track this.
It's possible to pass your own configuration object via {set,with}Configuration methods.
> Support JobConfigurable and Closable interfaces
> -----------------------------------------------
>
> Key: MRUNIT-14
> URL: https://issues.apache.org/jira/browse/MRUNIT-14
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.5.0
> Reporter: E. Sammer
> Assignee: Brock Noland
> Fix For: 0.8.0
>
>
> MRUnit should support the invocation of a mapper or reducer's configure() and close() methods as dictated by JobConfigurable and Closable respectively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-14) Support JobConfigurable and Closable
interfaces
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216567#comment-13216567 ]
Jim Donofrio commented on MRUNIT-14:
------------------------------------
I understand why you made this change for a JUnit test class with a single @Test method. However, calling configure and close prevents one from calling configure once in a @BeforeClass method and testing several (key, value) pairs in a series of separate @Test methods using the same static Mapper or Reduce instance. This more closely mirrors what the actual mapreduce does and allows one to make sure they are properly clearing state between different (key, value) pairs.
This change also makes 0.8.x non backwards compatible with mapreduce jobs that test with mrunit 0.5.0 since you will call configure again with an empty Configuration object after we already called it.
Maybe you could make calling configure and close configurable by us providing a boolean in a constructor to indicate whether you should call configure and close
> Support JobConfigurable and Closable interfaces
> -----------------------------------------------
>
> Key: MRUNIT-14
> URL: https://issues.apache.org/jira/browse/MRUNIT-14
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.5.0
> Reporter: E. Sammer
> Assignee: Brock Noland
> Fix For: 0.8.0
>
>
> MRUnit should support the invocation of a mapper or reducer's configure() and close() methods as dictated by JobConfigurable and Closable respectively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-14) Support JobConfigurable and Closable
interfaces
Posted by "E. Sammer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
E. Sammer updated MRUNIT-14:
----------------------------
Fix Version/s: 0.8.0
> Support JobConfigurable and Closable interfaces
> -----------------------------------------------
>
> Key: MRUNIT-14
> URL: https://issues.apache.org/jira/browse/MRUNIT-14
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.5.0
> Reporter: E. Sammer
> Fix For: 0.8.0
>
>
> MRUnit should support the invocation of a mapper or reducer's configure() and close() methods as dictated by JobConfigurable and Closable respectively.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira