[jira] [Comment Edited] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.

["Michael Brohl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283241#comment-17283241 ] 

Michael Brohl edited comment on OFBIZ-10150 at 2/11/21, 5:42 PM:
-----------------------------------------------------------------

[~jleroux] Do you still want this to be open as a bug?

Should we not better close this specific bug issue and create another one as an improvement?


was (Author: mbrohl):
[~jleroux] Do you still want this to be open as a bug?

Should we not better close this specifix bug issue and create another one as an improvement?

> supplierProductId Should Have Consistent Types Across Entities.
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-10150
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10150
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, product
>    Affects Versions: Release Branch 16.11, Release Branch 18.12, Release Branch 17.12, Trunk
>         Environment: all
>            Reporter: jesse thomas
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: OFBIZ-10150.patch
>
>
> During some data migration I hit an issue where my data for supplierProductId was too long. So I looked up the fields and noticed that the order item entity had a different type for the field than the supplier product entity. I think it would be a good idea to pick one so the two fields can be treated consistently. I would vote for id-long, but I think either way it would be good to have them be the same type. There are other fields that have this issue too if you are interested?
>   
> Thanks!
> applications/datamodel/entitydef/order-entitymodel.xml:      
> <entity entity-name="OrderItem".......
> <field name="supplierProductId" type="id-long"></field>
> applications/datamodel/entitydef/product-entitymodel.xml:      
> <entity entity-name="SupplierProduct"......
> <field name="supplierProductId" type="id"></field>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)