[GitHub] reminisce commented on a change in pull request #14123: Add int8 data loader

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #14123: Add int8 data loader
URL: https://github.com/apache/incubator-mxnet/pull/14123#discussion_r258729415
 
 

 ##########
 File path: src/operator/quantization/quantize_graph_pass.cc
 ##########
 @@ -156,6 +157,10 @@ Graph QuantizeGraph(Graph &&src) {
         if (avoid_quantize_input_map.count(node->op()) &&
             avoid_quantize_input_map[node->op()](node->attrs, i)) {
           new_node->inputs.emplace_back(mirror_entry);
+        // If network will directly accept quantized data, simply add data as input.
+        } else if (use_quantized_data_layer && e.node->is_variable() &&
+                   e.node->attrs.name == "data") {
 
 Review comment:
   This is a very strong assumption on the name of input variable node. One solution is allowing users to specify the names of inputs and pass them as a graph attribute. By default, it can be called `data` if not provided. Need to document the usage well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services