You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/04/21 21:19:12 UTC

Review Request 20533: Discarded the future returned by select when future.discard() is called.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20533/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/include/process/future.hpp f394a96 
  3rdparty/libprocess/src/tests/process_tests.cpp ff0ee75 

Diff: https://reviews.apache.org/r/20533/diff/


Testing
-------

make check

3rdparty/libprocess/tests --gtest_filter=*select* --gtest_repeat=1000


Thanks,

Jie Yu


Re: Review Request 20533: Discarded the future returned by select when future.discard() is called.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20533/#review40955
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On April 21, 2014, 7:19 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20533/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 7:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp f394a96 
>   3rdparty/libprocess/src/tests/process_tests.cpp ff0ee75 
> 
> Diff: https://reviews.apache.org/r/20533/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 3rdparty/libprocess/tests --gtest_filter=*select* --gtest_repeat=1000
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 20533: Discarded the future returned by select when future.discard() is called.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20533/#review40958
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On April 21, 2014, 7:19 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20533/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 7:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp f394a96 
>   3rdparty/libprocess/src/tests/process_tests.cpp ff0ee75 
> 
> Diff: https://reviews.apache.org/r/20533/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 3rdparty/libprocess/tests --gtest_filter=*select* --gtest_repeat=1000
> 
> 
> Thanks,
> 
> Jie Yu
> 
>