Re: [PR] SOLR-17093: Collection restore API returns requestid when executed asynchronously [solr]

["mariemat (via GitHub)" <gi...@apache.org>]

mariemat commented on code in PR #2111:
URL: https://github.com/apache/solr/pull/2111#discussion_r1561202416


##########
solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCollectionAPI.java:
##########
@@ -144,10 +144,14 @@ public SubResponseAccumulatingJerseyResponse restoreCollection(
       throw remoteResponse.getException();
     }
 
+    if (requestBody.async != null) {
+      response.requestId = requestBody.async;
+      return response;

Review Comment:
   I am curious to know if there is any reason to return here and skip the 2 lines below?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org