[lucene-solr] branch master updated: SOLR-14579: reverting incorrect comments

[er...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

erick pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/master by this push:
     new 594d676  SOLR-14579: reverting incorrect comments
594d676 is described below

commit 594d676a951a75038e1ebc5ed867a242b48c3149
Author: Erick Erickson <Er...@gmail.com>
AuthorDate: Tue Sep 1 18:59:08 2020 -0400

    SOLR-14579: reverting incorrect comments
---
 .../java/org/apache/solr/common/util/Utils.java    | 35 ----------------------
 1 file changed, 35 deletions(-)

diff --git a/solr/solrj/src/java/org/apache/solr/common/util/Utils.java b/solr/solrj/src/java/org/apache/solr/common/util/Utils.java
index 6aaa4d7..0a4485b 100644
--- a/solr/solrj/src/java/org/apache/solr/common/util/Utils.java
+++ b/solr/solrj/src/java/org/apache/solr/common/util/Utils.java
@@ -96,41 +96,6 @@ import static java.util.concurrent.TimeUnit.NANOSECONDS;
 
 
 public class Utils {
-  // Why static lambdas? Even though they require SuppressWarnings? This is
-  // purely an optimization. Comparing:
-  //
-  //    mapObject.computeIfAbsent(key, o -> new HashMap<>());
-  //
-  //    vs.
-  //
-  //    mapObject.computeIfAbsent(key, Utils.NEW_HASHMAP_FUN)
-  //
-  //
-  //    The first code fragment is executed as following
-  //
-  //    s.computeIfAbsent(key, new Function() {
-  //      @Override
-  //      public Object apply(String key) {
-  //        return new HashMap<>();
-  //      }
-  //    }
-  //
-  //    So, there are two problems with this
-  //
-  //    A new anonymous inner class is created for that lambda. This one extra
-  //    class becomes a part of your binary a new instance of that class is
-  //    created everytime the computeIfAbsent() method is invoked, irrespective
-  //    of whether the value is absent for that key or not. Now imagine that
-  //    method getting called millions of times and creating millions of such
-  //    objects for no reason
-  //
-  //    OTOH
-  //
-  //    Utils.NEW_HASHMAP_FUN
-  //    Only a single anonymous class is created for the entire codebase
-  //    Only single instance of that object is created in the VM
-  //
-  // See SOLR-14579.
 
   @SuppressWarnings({"rawtypes"})
   public static final Function NEW_HASHMAP_FUN = o -> new HashMap<>();