You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by linwen <gi...@git.apache.org> on 2015/10/19 11:03:52 UTC

[GitHub] incubator-hawq pull request: HAWQ-64. fix NULL pointer error in fu...

GitHub user linwen opened a pull request:

    https://github.com/apache/incubator-hawq/pull/28

    HAWQ-64. fix NULL pointer error in function ExtractPrincipalFromTicke…

    fix a bug. Please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/linwen/incubator-hawq hawq-64

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit 777932737fcd7bc2fd4e4fce7610ff1983f0ed5a
Author: Wen Lin <wl...@pivotal.io>
Date:   2015-10-19T09:02:55Z

    HAWQ-64. fix NULL pointer error in function ExtractPrincipalFromTicketCache

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-64. fix NULL pointer error in fu...

Posted by wangzw <gi...@git.apache.org>.
Github user wangzw commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/28#issuecomment-149155432
  
    Code is good to me except indent issue. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-64. fix NULL pointer error in fu...

Posted by linwen <gi...@git.apache.org>.
Github user linwen closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-64. fix NULL pointer error in fu...

Posted by wangzw <gi...@git.apache.org>.
Github user wangzw commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/28#discussion_r42350715
  
    --- Diff: src/backend/resourcemanager/resourcebroker/resourcebroker_LIBYARN_proc.c ---
    @@ -317,7 +317,7 @@ char * ExtractPrincipalFromTicketCache(const char* cache)
     		return NULL;
     	}
     
    -	if (!cache) {
    +	if (cache) {
    --- End diff --
    
    Please fix the indent issue here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-64. fix NULL pointer error in fu...

Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/28#issuecomment-149162071
  
    Look good to me.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---