You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/16 06:24:06 UTC
[GitHub] kristw commented on a change in pull request #6702: Fix for Airbnb
bug PRODUCT-62223 - Text field to edit SQL snippet of a metric is not large
enough for entire snippet
kristw commented on a change in pull request #6702: Fix for Airbnb bug PRODUCT-62223 - Text field to edit SQL snippet of a metric is not large enough for entire snippet
URL: https://github.com/apache/incubator-superset/pull/6702#discussion_r248162859
##########
File path: superset/assets/src/components/EditableTitle.jsx
##########
@@ -140,8 +153,29 @@ export default class EditableTitle extends React.PureComponent {
} else if (!this.state.isEditing) {
Review comment:
Let's deconstruct `this.state` and `this.props`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org