You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by mb...@apache.org on 2016/10/22 00:09:11 UTC
hbase git commit: HBASE-16815 Low scan ratio in RPC queue tuning
triggers divide by zero exception
Repository: hbase
Updated Branches:
refs/heads/branch-1.1 0bfa86658 -> 9b03a6b33
HBASE-16815 Low scan ratio in RPC queue tuning triggers divide by zero exception
Signed-off-by: Matteo Bertozzi <ma...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/9b03a6b3
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/9b03a6b3
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/9b03a6b3
Branch: refs/heads/branch-1.1
Commit: 9b03a6b339c8e69de9d5c9a9ddcd660c35220ae9
Parents: 0bfa866
Author: Guanghao Zhang <zg...@gmail.com>
Authored: Mon Oct 17 09:25:51 2016 +0800
Committer: Matteo Bertozzi <ma...@cloudera.com>
Committed: Fri Oct 21 17:07:51 2016 -0700
----------------------------------------------------------------------
.../apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/9b03a6b3/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
index 7b28e74..55da832 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
@@ -136,10 +136,9 @@ public class RWQueueRpcExecutor extends RpcExecutor {
this.scanBalancer = getBalancer(numScanQueues);
queues = new ArrayList<BlockingQueue<CallRunner>>(writeHandlersCount + readHandlersCount);
- LOG.debug(name + " writeQueues=" + numWriteQueues + " writeHandlers=" + writeHandlersCount +
- " readQueues=" + numReadQueues + " readHandlers=" + readHandlersCount +
- ((numScanQueues == 0) ? "" : " scanQueues=" + numScanQueues +
- " scanHandlers=" + scanHandlersCount));
+ LOG.info(name + " writeQueues=" + numWriteQueues + " writeHandlers=" + writeHandlersCount
+ + " readQueues=" + numReadQueues + " readHandlers=" + readHandlersCount + " scanQueues="
+ + numScanQueues + " scanHandlers=" + scanHandlersCount);
for (int i = 0; i < numWriteQueues; ++i) {
queues.add((BlockingQueue<CallRunner>)
@@ -156,8 +155,10 @@ public class RWQueueRpcExecutor extends RpcExecutor {
protected void startHandlers(final int port) {
startHandlers(".write", writeHandlersCount, queues, 0, numWriteQueues, port);
startHandlers(".read", readHandlersCount, queues, numWriteQueues, numReadQueues, port);
- startHandlers(".scan", scanHandlersCount, queues,
- numWriteQueues + numReadQueues, numScanQueues, port);
+ if (numScanQueues > 0) {
+ startHandlers(".scan", scanHandlersCount, queues, numWriteQueues + numReadQueues,
+ numScanQueues, port);
+ }
}
@Override